Skip to content

fix typo in "issue" in section 2.6 #35 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
walovens wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix typo in "issue" in section 2.6 #35 #42

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b97d529
fix a typo in the first line of section 2.5.1 #38
walovens Apr 16, 2024
42cca0b
fix typo in "issue" in section 2.6 #35
walovens Apr 16, 2024
f712f19
Merge branch 'IBEEM-MSU:main' into main
walovens Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 02-github-in-practice.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ Effective commits are an important communication tool for your collaborators, yo

## GitHub issue tracking

We've mentioned GitHub issue tracking several times. While isse tracking is not a git feature or necessary to use git, this feature has been a cornerstone of open source collaboration within and outside of software development teams.
We've mentioned GitHub issue tracking several times. While issue tracking is not a git feature or necessary to use git, this feature has been a cornerstone of open source collaboration within and outside of software development teams.

The basic concept of an issue and its' use is very simple. The second example of a commit above from the CRAWL project has an associated GitHub issue, and we know this because the dev who made the commit added a summary message "*longlat or geographic coordinate reference systems are not supported. this adds explicit checks and throws an error if geographic coordinates are provided. Fixes #39*" GitHub automatically links the issue ID number to the web page for the issue, which is
["add error catch when `sf` object is in 4326"](https://github.com/NMML/crawl/issues/39). Because the commit states it fixes this issue, we can assume that all the code necessary is in the commit, which you can confirm in the diff.
Expand Down