Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date-based versioning support for Code Engine #5951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add date-based versioning support for Code Engine #5951

wants to merge 2 commits into from

Conversation

jasonpet
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

/usr/bin/make -f /Users/jasonpet/go/src/github.ibm.com/coligo/terraform/Makefile -C /Users/jasonpet/go/src/github.ibm.com/coligo/terraform testacc
TF_ACC=1 go test -timeout 1800s -v $(go list ./... |grep -v 'vendor') 
?   	github.com/IBM-Cloud/terraform-provider-ibm	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/acctest	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/provider	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/validate	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/version	[no test files]
=== RUN   TestString
--- PASS: TestString (0.00s)
=== RUN   TestString_positiveIndex
--- PASS: TestString_positiveIndex (0.00s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/conns	0.573s
=== RUN   TestTerraformProblemEmbedsIBMProblem
--- PASS: TestTerraformProblemEmbedsIBMProblem (0.00s)
=== RUN   TestTerraformProblemGetConsoleMessage
--- PASS: TestTerraformProblemGetConsoleMessage (0.00s)
=== RUN   TestTerraformProblemGetDebugMessage
--- PASS: TestTerraformProblemGetDebugMessage (0.00s)
=== RUN   TestTerraformProblemGetID
--- PASS: TestTerraformProblemGetID (0.00s)
=== RUN   TestTerraformProblemGetConsoleOrderedMaps
--- PASS: TestTerraformProblemGetConsoleOrderedMaps (0.00s)
=== RUN   TestTerraformProblemGetDebugOrderedMaps
--- PASS: TestTerraformProblemGetDebugOrderedMaps (0.00s)
=== RUN   TestTerraformProblemGetDiag
--- PASS: TestTerraformProblemGetDiag (0.00s)
=== RUN   TestTerraformErrorf
--- PASS: TestTerraformErrorf (0.00s)
=== RUN   TestFmtErrorfWithProblem
--- PASS: TestFmtErrorfWithProblem (0.00s)
=== RUN   TestFmtErrorfWithNoError
--- PASS: TestFmtErrorfWithNoError (0.00s)
=== RUN   TestFmtErrorfWithProblemInServiceErrorResponse
--- PASS: TestFmtErrorfWithProblemInServiceErrorResponse (0.00s)
=== RUN   TestDiscriminatedTerraformErrorf
--- PASS: TestDiscriminatedTerraformErrorf (0.00s)
=== RUN   TestGetComponentInfo
--- PASS: TestGetComponentInfo (0.00s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex	0.617s

=== RUN   TestAccIbmCodeEngineAllowedOutboundDestinationDataSourceBasic
--- PASS: TestAccIbmCodeEngineAllowedOutboundDestinationDataSourceBasic (8.73s)
=== RUN   TestAccIbmCodeEngineAppDataSourceBasic
--- PASS: TestAccIbmCodeEngineAppDataSourceBasic (68.55s)
=== RUN   TestAccIbmCodeEngineAppDataSourceExtended
--- PASS: TestAccIbmCodeEngineAppDataSourceExtended (68.48s)
=== RUN   TestAccIbmCodeEngineBindingDataSourceBasic
--- PASS: TestAccIbmCodeEngineBindingDataSourceBasic (71.16s)
=== RUN   TestAccIbmCodeEngineBuildDataSourceBasic
--- PASS: TestAccIbmCodeEngineBuildDataSourceBasic (7.18s)
=== RUN   TestAccIbmCodeEngineConfigMapDataSourceBasic
--- PASS: TestAccIbmCodeEngineConfigMapDataSourceBasic (7.35s)
=== RUN   TestAccIbmCodeEngineDomainMappingDataSourceBasic
--- PASS: TestAccIbmCodeEngineDomainMappingDataSourceBasic (129.46s)
=== RUN   TestAccIbmCodeEngineFunctionDataSourceBasic
--- PASS: TestAccIbmCodeEngineFunctionDataSourceBasic (69.91s)
=== RUN   TestAccIbmCodeEngineFunctionDataSourceExtended
--- PASS: TestAccIbmCodeEngineFunctionDataSourceExtended (69.12s)
=== RUN   TestAccIbmCodeEngineJobDataSourceBasic
--- PASS: TestAccIbmCodeEngineJobDataSourceBasic (8.62s)
=== RUN   TestAccIbmCodeEngineJobDataSourceExtended
--- PASS: TestAccIbmCodeEngineJobDataSourceExtended (7.60s)
=== RUN   TestAccIbmCodeEngineProjectDataSourceBasic
--- PASS: TestAccIbmCodeEngineProjectDataSourceBasic (6.96s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceGeneric
--- PASS: TestAccIbmCodeEngineSecretDataSourceGeneric (7.55s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceBasicAuth
--- PASS: TestAccIbmCodeEngineSecretDataSourceBasicAuth (7.65s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceRegistry
--- PASS: TestAccIbmCodeEngineSecretDataSourceRegistry (7.60s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceSSHAuth
--- PASS: TestAccIbmCodeEngineSecretDataSourceSSHAuth (7.07s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceTls
--- PASS: TestAccIbmCodeEngineSecretDataSourceTls (8.41s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceServiceAccess
--- PASS: TestAccIbmCodeEngineSecretDataSourceServiceAccess (9.90s)
=== RUN   TestAccIbmCodeEngineAllowedOutboundDestinationBasic
--- PASS: TestAccIbmCodeEngineAllowedOutboundDestinationBasic (13.06s)
=== RUN   TestAccIbmCodeEngineAppBasic
--- PASS: TestAccIbmCodeEngineAppBasic (135.72s)
=== RUN   TestAccIbmCodeEngineAppExtended
--- PASS: TestAccIbmCodeEngineAppExtended (137.17s)
=== RUN   TestAccIbmCodeEngineBindingBasic
--- PASS: TestAccIbmCodeEngineBindingBasic (71.89s)
=== RUN   TestAccIbmCodeEngineBuildBasic
--- PASS: TestAccIbmCodeEngineBuildBasic (7.32s)
=== RUN   TestAccIbmCodeEngineConfigMapBasic
--- PASS: TestAccIbmCodeEngineConfigMapBasic (14.48s)
=== RUN   TestAccIbmCodeEngineDomainMappingBasic
--- PASS: TestAccIbmCodeEngineDomainMappingBasic (135.75s)
=== RUN   TestAccIbmCodeEngineFunctionBasic
--- PASS: TestAccIbmCodeEngineFunctionBasic (76.62s)
=== RUN   TestAccIbmCodeEngineFunctionExtended
--- PASS: TestAccIbmCodeEngineFunctionExtended (74.60s)
=== RUN   TestAccIbmCodeEngineJobBasic
--- PASS: TestAccIbmCodeEngineJobBasic (14.15s)
=== RUN   TestAccIbmCodeEngineJobExtended
--- PASS: TestAccIbmCodeEngineJobExtended (16.43s)
=== RUN   TestAccIbmCodeEngineProjectBasic
--- PASS: TestAccIbmCodeEngineProjectBasic (54.76s)
=== RUN   TestAccIbmCodeEngineSecretGeneric
--- PASS: TestAccIbmCodeEngineSecretGeneric (16.23s)
=== RUN   TestAccIbmCodeEngineSecretBasicAuth
--- PASS: TestAccIbmCodeEngineSecretBasicAuth (14.42s)
=== RUN   TestAccIbmCodeEngineSecretRegistry
--- PASS: TestAccIbmCodeEngineSecretRegistry (14.17s)
=== RUN   TestAccIbmCodeEngineSecretSSHAuth
--- PASS: TestAccIbmCodeEngineSecretSSHAuth (14.82s)
=== RUN   TestAccIbmCodeEngineSecretTls
--- PASS: TestAccIbmCodeEngineSecretTls (14.12s)
=== RUN   TestAccIbmCodeEngineSecretServiceAccess
--- PASS: TestAccIbmCodeEngineSecretServiceAccess (9.69s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine	1407.504s

...

hkantare
hkantare reviewed Jan 31, 2025
View reviewed changes
ibm/provider/provider.go
@@ -179,6 +179,12 @@ func Provider() *schema.Provider {
Description: "The retry count to set for API calls.",
DefaultFunc: schema.EnvDefaultFunc("MAX_RETRIES", 10),
},
"code_engine_version": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In provider schema we will have only those attributes which is common for all services under IBM Cloud.
We can't have service specific config params at provider level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional information on what we are attempting to do can be found here: https://ibm-cloudplatform.slack.com/archives/C4XC6SWKG/p1736451691992129

Please let us know once you have an idea on how to best handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonpet @hkantare