Skip to content

Conversation

@ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Oct 10, 2025

This pull request deprecates name fields for id fields. In either case (before and after this change), the user can put either the name or id and resource will be fetched. The reason for this change is that APP Config team is fetching tons of resources and sometimes if you use the name the cache could fail or fetch stale data. The ID is more reliable. This change is to encourage the user to use IDs instead of names.

Output from acceptance testing:

--- PASS: TestAccIBMPIKeyDataSource_basic (11.29s)
PASS

@ismirlia ismirlia requested a review from michaelkad October 10, 2025 14:21
@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Oct 10, 2025
@ismirlia ismirlia changed the title Deprecate Arg_KeyName for Arg_SSHKeyID Fix ibm_pi_key data source to use id Oct 10, 2025
@ismirlia ismirlia requested a review from yussufsh October 10, 2025 14:32
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs as well.

@michaelkad michaelkad requested a review from yussufsh October 13, 2025 15:41
Update doc to add deprecation
@michaelkad
Copy link
Collaborator

--- PASS: TestAccIBMPIKeyDataSource_basic (34.37s)
PASS

@yussufsh yussufsh merged commit 3bc504c into IBM-Cloud:master Oct 16, 2025
1 check passed
@yussufsh yussufsh deleted the ssh-key-attribute branch October 16, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service/Power Systems Issues related to Power Systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants