feat(identity): add new account settings #6538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariarla
requested review from
hkantare,
kavya498,
omaraibrahim and
uibm
as code owners
hariarla
force-pushed
the
enable_identity_new_settings
branch
from
e185da5 to
c5703c9
Compare
hkantare
reviewed
Nov 5, 2025
Contributor
|
code changes from api level looks good to me, |
Daniel-Byrne
suggested changes
Nov 6, 2025
Contributor
Daniel-Byrne
left a comment
Daniel-Byrne
left a comment
There was a problem hiding this comment.
Thanks Hari! Template data source/resource changes look. I just some comments on the effective settings.
ibm/service/iamidentity/data_source_ibm_iam_effective_account_settings.go
Outdated
Show resolved
Hide resolved
ibm/service/iamidentity/data_source_ibm_iam_effective_account_settings.go
Outdated
Show resolved
Hide resolved
ibm/service/iamidentity/data_source_ibm_iam_effective_account_settings.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Hari K Arla <[email protected]>
hariarla
force-pushed
the
enable_identity_new_settings
branch
from
c5703c9 to
c7f32d5
Compare
hkantare
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: