Disable a few EC curves in computing shared secret #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinhangZhang
force-pushed
the
openjceplus/bug/ecdhkeyagreementp192curve
branch
2 times, most recently
from
9075a03 to
50b0177
Compare
According to the policy, curve size less than 192 should not be allowed in computing shared secret in ECDH keyagreement in FIPS 140-3 mode. This PR proposes an option to enable/disable this behaviour. Signed-off-by: JinhangZhang <[email protected]>
JinhangZhang
force-pushed
the
openjceplus/bug/ecdhkeyagreementp192curve
branch
from
142a25e to
658cc4d
Compare
JinhangZhang
requested review from
KostasTsiounis,
jasonkatonica,
johnpeck-us-ibm and
taoliult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the policy, curve size less than 192 should not be allowed in computing shared secret in ECDH keyagreement.