Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters #833
+2,409
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-koan
force-pushed
the
implement_pbe
branch
from
d306af6 to
b6911e0
Compare
dev-koan
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
taoliult
jasonkatonica
requested changes
Oct 7, 2025
| SecretKeyFactory | PBKDF2WithHmacSHA224 |X |X | | | ||
| SecretKeyFactory | PBKDF2WithHmacSHA256 |X |X | | | ||
| SecretKeyFactory | PBKDF2WithHmacSHA384 |X |X | | | ||
| SecretKeyFactory | PBKDF2WithHmacSHA512 |X |X | | |
There was a problem hiding this comment.
I have noticed that there is also Mac services that make use of PBE also. For example on Java 25 do we want to intentionally skip these for now?
SunJCE: Mac.PBEWithHmacSHA512/224 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA384
SunJCE: Mac.PBEWithHmacSHA256
SunJCE: Mac.PBEWithHmacSHA224
SunJCE: Mac.PBEWithHmacSHA224 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA256 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA512/256
SunJCE: Mac.PBEWithHmacSHA512/256 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA1 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA384 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA1
SunJCE: Mac.PBEWithHmacSHA512/224
SunJCE: Mac.PBEWithHmacSHA512
SunJCE: Mac.PBEWithHmacSHA512 SupportedKeyFormats
There was a problem hiding this comment.
I am not sure about this, we can discuss if we would want to add these
src/test/java/ibm/jceplus/junit/base/BaseTestPBEParameters.java
Outdated
Show resolved
Hide resolved
dev-koan
force-pushed
the
implement_pbe
branch
3 times, most recently
from
3321ceb to
cea7626
Compare
dev-koan
force-pushed
the
implement_pbe
branch
from
cea7626 to
bb0ecf1
Compare
dev-koan
commented
Oct 10, 2025
dev-koan
commented
Oct 10, 2025
jasonkatonica
requested changes
Oct 10, 2025
src/test/java/ibm/jceplus/junit/openjceplus/TestPBEParameters.java
Outdated
Show resolved
Hide resolved
dev-koan
force-pushed
the
implement_pbe
branch
from
bb0ecf1 to
52f952c
Compare
KostasTsiounis
requested changes
Oct 14, 2025
dev-koan
force-pushed
the
implement_pbe
branch
from
52f952c to
e7f368c
Compare
jasonkatonica
requested changes
Oct 15, 2025
dev-koan
force-pushed
the
implement_pbe
branch
from
e7f368c to
51b2c56
Compare
jasonkatonica
requested changes
Oct 16, 2025
|
Performance seems good to me here vs the OpenJDK providers: For example on linux x86 here is a small sample of the decrypt benchmark results: And encrypt on x86 linux: The full set of data is attached here for AIX, ppcle linux, and x86 linux: |
dev-koan
force-pushed
the
implement_pbe
branch
2 times, most recently
from
5d492c9 to
7c24df7
Compare
JinhangZhang
requested changes
Oct 16, 2025
dev-koan
force-pushed
the
implement_pbe
branch
from
7c24df7 to
3481839
Compare
taoliult
reviewed
Oct 16, 2025
src/main/java/com/ibm/crypto/plus/provider/PBES2Parameters.java
Outdated
Show resolved
Hide resolved
dev-koan
force-pushed
the
implement_pbe
branch
from
3481839 to
1fb142e
Compare
This update adds support for PBES2, PBEKeyFactory, PBEKey, and PBEParameters for PBE algorithms with Hmac and AES for OpenJCEPlus provider. Signed-off-by: Dev Agarwal <[email protected]>
dev-koan
force-pushed
the
implement_pbe
branch
from
1fb142e to
07aaa88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for PBES2, PBEKeyFactory, PBEKey, and PBEParameters for PBE algorithms with Hmac and AES for OpenJCEPlus provider.
Signed-off-by: Dev Agarwal [email protected]