-
Notifications
You must be signed in to change notification settings - Fork 18
Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d306af6
to
b6911e0
Compare
SecretKeyFactory | PBKDF2WithHmacSHA224 |X |X | | | ||
SecretKeyFactory | PBKDF2WithHmacSHA256 |X |X | | | ||
SecretKeyFactory | PBKDF2WithHmacSHA384 |X |X | | | ||
SecretKeyFactory | PBKDF2WithHmacSHA512 |X |X | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed that there is also Mac
services that make use of PBE also. For example on Java 25 do we want to intentionally skip these for now?
SunJCE: Mac.PBEWithHmacSHA512/224 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA384
SunJCE: Mac.PBEWithHmacSHA256
SunJCE: Mac.PBEWithHmacSHA224
SunJCE: Mac.PBEWithHmacSHA224 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA256 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA512/256
SunJCE: Mac.PBEWithHmacSHA512/256 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA1 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA384 SupportedKeyFormats
SunJCE: Mac.PBEWithHmacSHA1
SunJCE: Mac.PBEWithHmacSHA512/224
SunJCE: Mac.PBEWithHmacSHA512
SunJCE: Mac.PBEWithHmacSHA512 SupportedKeyFormats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this, we can discuss if we would want to add these
src/test/java/ibm/jceplus/junit/base/BaseTestPBEParameters.java
Outdated
Show resolved
Hide resolved
3321ceb
to
cea7626
Compare
cea7626
to
bb0ecf1
Compare
src/test/java/ibm/jceplus/junit/openjceplus/TestPBEParameters.java
Outdated
Show resolved
Hide resolved
bb0ecf1
to
52f952c
Compare
52f952c
to
e7f368c
Compare
e7f368c
to
51b2c56
Compare
Performance seems good to me here vs the OpenJDK providers: For example on linux x86 here is a small sample of the decrypt benchmark results: The full set of data is attached here for AIX, ppcle linux, and x86 linux: |
5d492c9
to
7c24df7
Compare
7c24df7
to
3481839
Compare
src/main/java/com/ibm/crypto/plus/provider/PBES2Parameters.java
Outdated
Show resolved
Hide resolved
3481839
to
1fb142e
Compare
This update adds support for PBES2, PBEKeyFactory, PBEKey, and PBEParameters for PBE algorithms with Hmac and AES for OpenJCEPlus provider. Signed-off-by: Dev Agarwal <[email protected]>
1fb142e
to
07aaa88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This update adds support for PBES2, PBEKeyFactory, PBEKey, and PBEParameters for PBE algorithms with Hmac and AES for OpenJCEPlus provider.
Signed-off-by: Dev Agarwal [email protected]