Skip to content

Refactor ECPrivateKey and allow getting public key #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor ECPrivateKey and allow getting public key #834

wants to merge 1 commit into from
+363 −458

Conversation

KostasTsiounis
Copy link
Member

The ECPrivateKey class is refactored to consolidate a single point of performing encoding operations.

Functionality is added to allow saving the public key if provided with the private key encoding.

Signed-off-by: Kostas Tsiounis [email protected]

johnpeck-us-ibm
johnpeck-us-ibm requested changes Oct 9, 2025
View reviewed changes
Copy link
Member

@johnpeck-us-ibm johnpeck-us-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are testing Key import we should try importing the key from SunEC as well. Also, having some hard coded encodings and importing from those is another good test.

@KostasTsiounis
Copy link
Member Author

If we are testing Key import we should try importing the key from SunEC as well. Also, having some hard coded encodings and importing from those is another good test.

We are already importing Sun and BC keys in the BaseTestECKeyImportInterop class. I can add some hard-coded ones for good measure though.

@KostasTsiounis
Refactor ECPrivateKey and allow getting public key
3fd000c 
The ECPrivateKey class is refactored to consolidate
a single point of performing encoding operations.

Functionality is added to allow saving the public
key if provided with the private key encoding.

Signed-off-by: Kostas Tsiounis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taoliult taoliult Awaiting requested review from taoliult

@jasonkatonica jasonkatonica Awaiting requested review from jasonkatonica

@JinhangZhang JinhangZhang Awaiting requested review from JinhangZhang

@johnpeck-us-ibm johnpeck-us-ibm Awaiting requested review from johnpeck-us-ibm

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KostasTsiounis @johnpeck-us-ibm