Skip to content

Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: java17
Choose a base branch
from
Open

Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters #900

wants to merge 1 commit into from
+2,515 −165

Conversation

@dev-koan
Copy link
Collaborator

@dev-koan dev-koan commented Oct 31, 2025

This update adds support for PBES2, PBEKeyFactory, PBEKey, and PBEParameters for PBE algorithms with Hmac and AES for OpenJCEPlus provider.

Back-ported from: #833

Signed-off-by: Dev Agarwal [email protected]

@dev-koan
Copy link
Collaborator Author

dev-koan commented Oct 31, 2025 •
edited
Loading

FYI
-> Modified hashcode() in PBEKey.java to return the same value as jdk17.
-> Added PBEUtil.java file as it doesn't exist in jdk17 and back
-> PBES2Parameter.java was modified with a change in parseKDF() compared to main.
-> PBE algorithms with the hash function SHA512\224 or SHA512\256 were removed as they are not supported in the base Cipher.java in openjdk. In this function openjdk doesn't account for algorithms having \ in the name which can found in the newer jdk version (here)

@dev-koan dev-koan force-pushed the implement_pbe_17 branch 3 times, most recently from f726aaa to e40e967 Compare November 3, 2025 05:34
@dev-koan dev-koan requested review from KostasTsiounis, jasonkatonica and taoliult and removed request for jasonkatonica November 3, 2025 11:22
jasonkatonica
jasonkatonica requested changes Nov 3, 2025
View reviewed changes
README.md

The following algorithms are registered by the OpenJCEPlus and OpenJCEPlusFIPS providers.

| Algorithm Type | Algorithm Name | OpenJCEPlusFIPS | OpenJCEPlus | Notes |
Copy link
Member

@jasonkatonica jasonkatonica Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this table match the column widths of main branch. I do acknowledge that the 512/224,512/256 have been removed but the rest of the table i think has different formatting. Keeping the table as close as possible to other branches makes it easier to maintain.

Copy link
Collaborator Author

@dev-koan dev-koan Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@dev-koan
Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters
1b95b61 
This update adds support for PBES2, PBEKeyFactory, PBEKey,
and PBEParameters for PBE algorithms with Hmac and AES for
OpenJCEPlus provider.

Signed-off-by: Dev Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KostasTsiounis KostasTsiounis Awaiting requested review from KostasTsiounis

@taoliult taoliult Awaiting requested review from taoliult

@JinhangZhang JinhangZhang Awaiting requested review from JinhangZhang

@johnpeck-us-ibm johnpeck-us-ibm Awaiting requested review from johnpeck-us-ibm

@jasonkatonica jasonkatonica Awaiting requested review from jasonkatonica

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dev-koan @jasonkatonica