Skip to content

Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters #910

merged 1 commit into from
Nov 6, 2025
+2,513 −138

Conversation

@dev-koan
Copy link
Collaborator

@dev-koan dev-koan commented Nov 3, 2025

This update adds support for PBES2, PBEKeyFactory, PBEKey, and PBEParameters for PBE algorithms with Hmac and AES for OpenJCEPlus provider.

Back-ported from: #833

Signed-off-by: Dev Agarwal [email protected]

@dev-koan
Copy link
Collaborator Author

dev-koan commented Nov 3, 2025 •
edited
Loading

FYI
-> Modified hashcode() to return the same value as jdk17.
-> Added PBEUtil.java file as it doesn't exist in jdk17 and back
-> PBES2Parameter.java was modified with a change in parseKDF() compared to main.
-> Slight changes in PBEKey.java as jdk11 is an older version and doesn't support some things
-> PBE algorithms with the hash function SHA512\224 or SHA512\256 were removed as they are not supported in the base Cipher.java in openjdk. In this function openjdk doesn't account for algorithms having \ in the name which can found in the newer jdk version (here)

@dev-koan dev-koan force-pushed the implement_pbe_11 branch 2 times, most recently from d61175c to 7016dd7 Compare November 3, 2025 10:50
@dev-koan dev-koan force-pushed the implement_pbe_11 branch 2 times, most recently from 37a2fc3 to b831d83 Compare November 6, 2025 14:56
jasonkatonica
jasonkatonica approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@jasonkatonica jasonkatonica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dev-koan
Support for PBES2, PBEKeyfactory, PBEKey and PBEParameters
c85d876 
This update adds support for PBES2, PBEKeyFactory, PBEKey,
and PBEParameters for PBE algorithms with Hmac and AES for
OpenJCEPlus provider.

Signed-off-by: Dev Agarwal <[email protected]>
KostasTsiounis
KostasTsiounis approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@KostasTsiounis KostasTsiounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonkatonica jasonkatonica merged commit 589439b into IBM:java11 Nov 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KostasTsiounis KostasTsiounis KostasTsiounis approved these changes

@jasonkatonica jasonkatonica jasonkatonica approved these changes

@johnpeck-us-ibm johnpeck-us-ibm johnpeck-us-ibm approved these changes

@taoliult taoliult Awaiting requested review from taoliult

@JinhangZhang JinhangZhang Awaiting requested review from JinhangZhang

Assignees

@dev-koan dev-koan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dev-koan @KostasTsiounis @jasonkatonica @johnpeck-us-ibm