Update Golang version to 1.17 #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojito317
approved these changes
Feb 7, 2022
.secrets.baseline
Outdated
| @@ -3,7 +3,7 @@ | |||
| "files": "stubs/.+\\.json|go.sum|^.secrets.baseline$", | |||
| "lines": null | |||
| }, | |||
| "generated_at": "2021-12-22T14:20:39Z", | |||
| "generated_at": "2022-02-04T14:56:37Z", | |||
There was a problem hiding this comment.
If none has changed the baseline file, we do not need to regenerate it.
|
Technically this works, but let's wait with merging till 1.18 officially released https://tip.golang.org/doc/go1.18 |
emlaver
force-pushed
the
242-update-golang
branch
from
7a40d81 to
9ce507e
Compare
eiri
approved these changes
Mar 24, 2022
mojito317
reviewed
Mar 24, 2022
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
| @@ -21,7 +21,7 @@ assignees: '' | |||
|
|
|||
| **Must gather (please complete the following information):** | |||
| - SDK Version [e.g. 1.2.1] | |||
| - Go Version [e.g. Go 1.16.8] | |||
| - Go Version [e.g. Go 1.17] | |||
There was a problem hiding this comment.
If you change this file here, it's going to be reverted on the next generated PR. Please do this change in the generator repo.
There was a problem hiding this comment.
Opened PR in sdks repo
There was a problem hiding this comment.
Reverted in 8110401
mojito317
reviewed
Mar 24, 2022
README.md
Outdated
| @@ -99,7 +99,7 @@ project: | |||
| service instance or a | |||
| [CouchDB](https://docs.couchdb.org/en/latest/install/index.html) | |||
| server. | |||
| - Go version 1.16 or 1.17. | |||
| - Go version 1.17 or 1.18. | |||
mojito317
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
I approve this in advance the fix of https://github.com/IBM/cloudant-go-sdk/pull/245/files#r834610384
emlaver
force-pushed
the
242-update-golang
branch
from
ed7f265 to
61de2b3
Compare
emlaver
force-pushed
the
242-update-golang
branch
from
61de2b3 to
ca638f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes: #242
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
Golang minimum version is 1.16
What is the new behavior?
Update minimum supported Golang version to 1.17
Does this PR introduce a breaking change?
Other information