Merged
Conversation
e3c935e to
d0d5bfa
Compare
Contributor
Author
|
Strange. Tests on Python 3.7 passed on my own fork. |
Member
|
Thanks so much for this! Two comments:
|
Contributor
Author
|
Agreed that Python 3.7 should just be removed. I would also suggest adding 3.11 and maybe 3.12. requirements.txt was added because it's necessary for caching support in GitHub Actions. Agreed that the duplication is bad and reading that in setup.py seems like a good solution. |
Contributor
Author
|
I will say however that the two are intended for different purposes and arguably should be kept separate. |
Contributor
Author
|
Also, apparently specifying a single |
Signed-off-by: Michael Mior <mmior@mail.rit.edu>
d0d5bfa to
cdf1531
Compare
Contributor
Author
|
Okay, I've updated the PR to test against Python 3.8-3.12 and removed the duplication in |
Member
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the Travis CI configuration and runs tests on GitHub Actions instead. For now I've just removed Codecov, but this at least gets the tests running again. Also supercedes #18.