Fix join of enum with string #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichel-aiven
force-pushed
the
kmichel-fix-join-enum-string
branch
from
c61b1ae to
c4e75d2
Compare
|
The tests are flaky because of non-repeatable canonicalization: #29 I'll also make a PR to fix the underlying bug when escaping regexp in a way that greenery doesn't like. |
|
when you get a chance, could you please rebase this against the latest? |
The join of a string restricted by a pattern with an unrestricted string is the unrestricted string, because it contains every possible string.
If s2 is a regex and s1 is empty or None, then s1 is equivalent to all the strings, but s2 can also be a regex equivalent to all the strings (for instance `.*|[abc]`). In that case, the two regex are equivalent and subsets of each other.
kmichel-aiven
force-pushed
the
kmichel-fix-join-enum-string
branch
from
c4e75d2 to
2b4105a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The join of a string restricted by a pattern with an unrestricted string is the unrestricted string, because it contains every possible string.