Added alembic script to resize url and slug columns to 191 #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmveeresh
requested review from
crivetimihai,
kevalmahajan and
madhav165
as code owners
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
- Update db.py SQLAlchemy model to match migration (String(191)) - Add dialect-specific SQL handling in migration (SQLite, PostgreSQL, MySQL) - Use CHAR_LENGTH for character-based truncation (not byte-based LENGTH in MySQL) - Ensure truncation works correctly across all supported database backends
- SQLite doesn't support ALTER COLUMN TYPE directly - Use batch_alter_table for SQLite (creates temp table, copies data, renames) - Keep direct ALTER COLUMN for PostgreSQL and MySQL - Applies to both upgrade and downgrade operations - Fixes: sqlalchemy.exc.OperationalError with SQLite
crivetimihai
force-pushed
the
migration/resize-url-slug-columns
branch
from
05b2a53 to
97bb774
Compare
Signed-off-by: Veeresh K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧾 PR Summary: Resize
slugandurlColumns to 191 CharactersBackground
In the existing schema, the following columns had larger lengths:
slug→VARCHAR(255)url→VARCHAR(767)These lengths exceeded typical index length limits on some databases (especially MySQL with UTF8MB4 encoding), potentially causing compatibility or index creation issues.
Change Summary
This migration adjusts both columns to a consistent and safer maximum length of 191 characters.
Migration Details
Upgrade (
2f67b12600b4 → 878e287d2366):slug:VARCHAR(255)→VARCHAR(191)url:VARCHAR(767)→VARCHAR(191)Downgrade (
878e287d2366 → 2f67b12600b4):slug:VARCHAR(191)→VARCHAR(255)url:VARCHAR(191)→VARCHAR(767)Rationale
Verification