fix: make schema path de-resolution utility more robust (#685)

Before, the check used faulty logic to determine if we were on the last
iteration through a loop. This could lead to unintended behavior in rare
cases. This clarifies the logic to only execute the last time through the
loop and for no other reason (the potential reason being if the last path
segment matched an earlier path segment).

Signed-off-by: Dustin Popp <[email protected]>

packages/ruleset/src/utils/get-schema-name-at-path.js

@@ -1,5 +1,5 @@
 /**
- * Copyright 2023 IBM Corporation.
+ * Copyright 2023 - 2024 IBM Corporation.
  * SPDX-License-Identifier: Apache2.0
  */
 
@@ -42,17 +42,22 @@ function getSchemaNameAtPath(path, pathToReferencesMap) {
   // pathToReferencesMap (which comes from graph nodes that Spectral gives us).
   // See the function documentation above for more info.
   let pathBuilder = '';
-  for (const pathSegment of path.split('.')) {
+  const pathSegments = path.split('.');
+
+  for (let i = 0; i < pathSegments.length; i++) {
+    const segment = pathSegments[i];
     if (pathBuilder) {
       pathBuilder += '.';
     }
-    pathBuilder += `${pathSegment}`;
+
+    pathBuilder += `${segment}`;
     const schemaReference = pathToReferencesMap[pathBuilder];
 
     // If it is the last time through the loop, we should definitely
     // find a schema reference - but we don't want to throw away the
     // path. We'll find the reference again at the end of this function.
-    if (schemaReference && pathSegment !== path.split('.').at(-1)) {
+    const lastTimeThrough = i === pathSegments.length - 1;
+    if (schemaReference && !lastTimeThrough) {
       pathBuilder = schemaReference;
     }
   }