Skip to content

Conversation

@prestodb-ci
Copy link
Collaborator

Test PR for branch staging-d537e4d03-pr with head d537e4d

zhouyuan and others added 27 commits October 17, 2025 07:44
…kincubator#15273)

Summary:
Pull Request resolved: facebookincubator#15273

As title

Reviewed By: mbasmanova

Differential Revision: D85431595

fbshipit-source-id: 1e5c9dc38a8268a8a57bbb1f45a652077dc05cb3
…ialization (facebookincubator#15226)

Summary:
Pull Request resolved: facebookincubator#15226

Refactor LocalRunnerService to use PrestoBatchSerializer instead of crafting output values manually using Thrift structs.

This is not just a much cleaner solution but is much faster as well.

Reviewed By: kagamiori

Differential Revision: D84964586

fbshipit-source-id: 8fbce053f0fa8931937fc041e87c521ec71e1b8c
…ebookincubator#15243)

Summary:
Add support for whitespaces after $.

Also, optimize json path normalization to use state machine instead of regular expression.

Address facebookincubator#14801 (comment)

Pull Request resolved: facebookincubator#15243

Reviewed By: Yuhta

Differential Revision: D85338852

Pulled By: mbasmanova

fbshipit-source-id: fd481cddc4377ac0e7672dcd0d4dfee2cd408d18
Summary:
Pull Request resolved: facebookincubator#15275

Removing unsafe unimplemented function

Reviewed By: mbasmanova

Differential Revision: D85411943

fbshipit-source-id: dc4f4280654188a1f5ddbe86ff0cc50271a83814
Summary:
Replaced VeloxCon videos with VeloxCon China banner

<img width="1616" height="736" alt="image" src="https://github.com/user-attachments/assets/96644311-cddf-47ec-b554-3fdcd649e1b2" />

Pull Request resolved: facebookincubator#15238

Reviewed By: mbasmanova

Differential Revision: D85441684

Pulled By: pedroerp

fbshipit-source-id: c6b99e592d3d0d2a09ead978c47700cc8180d1dc
fix decimal avg function precision issue

Signed-off-by: Yuan <[email protected]>

Alchemy-item: (ID = 518) [6020 ] Spark sql avg agg function support decimal commit 1/1 - 0cd1be1
And reverts facebookincubator#14934

Alchemy-item: (ID = 679) [oap   ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
Address comments

disable by default

Alchemy-item: (ID = 532) feat: Build hash table while adding input rows for left semi and anti join commit 1/1 - 73ee99f
Signed-off-by: Yuan <[email protected]>

Alchemy-item: (ID = 476) [11067] Support scan filter for decimal in ORC commit 1/1 - b432008
The function toValues removes duplicated values from the vector and
return them in a std::vector. It was used to build an InPredicate. It
will be needed for building NOT IN filters for Iceberg equality delete
read as well, therefore moving it from velox/functions/prestosql/InPred
icate.cpp to velox/type/Filter.h. This commit also renames it to
deDuplicateValues to make it easier to understand.

Alchemy-item: (ID = 754) Iceberg staging hub commit 1/11 - 4aa9c1f
This commit introduces EqualityDeleteFileReader, which is used to read
Iceberg splits with equality delete files. The equality delete files
are read to construct domain filters or filter functions, which then
would be evaluated in the base file readers.

When there is only one equality delete field, and when that field is
an Iceberg identifier field, i.e. non-floating point primitive types,
the values would be converted to a list as a NOT IN domain filter,
with the NULL treated separately. This domain filter would then be
pushed to the ColumnReaders to filter our unwanted rows before they
are read into Velox vectors. When the equality delete column is a
nested column, e.g. a sub-column in a struct, or the key in a map,
such column may not be in the base file ScanSpec. We need to add/remove
these subfields to/from the SchemaWithId and ScanSpec recursively if
they were not in the ScanSpec already. A test is also added for such
case.

If there are more than one equality delete field, or the field is not
an Iceberg identifier field, the values would be converted to a typed
expression in the conjunct of disconjunts form. This expression would
be evaluated as the remaining filter function after the rows are read
into the Velox vectors. Note that this only works for Presto now as
the "neq" function is not registered by Spark. See https://github.com/
facebookincubator/issues/12667

Note that this commit only supports integral types. VARCHAR and
VARBINARY need to be supported in future commits (see
facebookincubator#12664).

Co-authored-by: Naveen Kumar Mahadevuni <[email protected]>

# Conflicts:
#	velox/connectors/hive/iceberg/tests/IcebergReadTest.cpp

Alchemy-item: (ID = 754) Iceberg staging hub commit 2/11 - 0b21ca2
Alchemy-item: (ID = 754) Iceberg staging hub commit 3/11 - cdcd1dc
Co-authored-by: Chengcheng Jin <[email protected]>

Alchemy-item: (ID = 754) Iceberg staging hub commit 4/11 - a48a3cf
Alchemy-item: (ID = 754) Iceberg staging hub commit 5/11 - 0608c68
Alchemy-item: (ID = 754) Iceberg staging hub commit 6/11 - e8a8386
…finity.

Alchemy-item: (ID = 754) Iceberg staging hub commit 7/11 - 6bf461f
Alchemy-item: (ID = 754) Iceberg staging hub commit 8/11 - b9bf7f3
Alchemy-item: (ID = 754) Iceberg staging hub commit 9/11 - 5178cf8
Alchemy-item: (ID = 754) Iceberg staging hub commit 10/11 - 8fa166f
Alchemy-item: (ID = 754) Iceberg staging hub commit 11/11 - fa08c07
Signed-off-by: Yuan <[email protected]>

Alchemy-item: (ID = 614) Support struct schema evolution matching by name commit 1/1 - 6ce34e0
Alchemy-item: (ID = 625) 13620 fix: Allow reading integers into smaller-range types commit 1/1 - 55dd46a
Signed-off-by: Yuan <[email protected]>

Alchemy-item: (ID = 569) [11771] Fix smj result mismatch issue commit 1/1 - 26a08a6
Signed-off-by: Yuan <[email protected]>

Alchemy-item: (ID = 724) fix: Adding daily tests commit 1/1 - e2eb2c6
Signed-off-by: Yuan <[email protected]>

Alchemy-item: (ID = 756) fix: Remove website folder to bypass the security issues commit 1/1 - f7b127b
@prestodb-ci
Copy link
Collaborator Author

@prestodb-ci prestodb-ci deleted the staging-d537e4d03-pr branch October 25, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.