Connector refactor part 1: Copy Hive and Iceberg code to connectors/lakehouse #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will be moving Iceberg connector to connectors/lakehouse, which will host all lakehouse connectors like Hudi, Deltalake, etc. These connectors would require file system supports in storage_adapters folder. This commit copies it over, so that all future lakehouse connectors can use it.
The Hive code was mostly used as base of Iceberg code. This commit copies the code from connectors/hive to connectors/lakehouse/common. Future commits will adapt them to base classes of future lakehouse connectors.
yingsu00
changed the title
yingsu00
requested review from
majetideepak
and removed request for
majetideepak
FelixYBW
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step of refactoring Velox’s built-in Iceberg support into its own standalone connector under a new connectors/lakehouse/iceberg hierarchy. By decoupling Iceberg from the Hive connector, we lay the groundwork for a true plugin architecture that:
What’s changed
Currently it is only a plain copy of the existing Hive-based implementations. It is not included in the build and will not break any CI. In follow-up work we’ll update their headers/namespaces, add necessary changes to make them build, remove Hive dependencies, clean up the implementations and add more features.