feat: /v1/query/{prepare,execute} endpoints for span queries
#90
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
|
||
| ## Span Queries | ||
|
|
||
| This directory contains a [span query](https://github.com/IBM/spnl#readme). To send a query, first prepare the query shape: |
There was a problem hiding this comment.
Should we add a preamble about how to deploy the server before running these queries against it?
There was a problem hiding this comment.
good idea. having a turnkey approach would be good.
it also occurs to me that this README only documents the RAG use case, not the nested generation use case.
starpit
force-pushed
the
spnl-ibm
branch
2 times, most recently
from
a3cbba6 to
de493c5
Compare
tdoublep
force-pushed
the
main
branch
2 times, most recently
from
6f7de33 to
5a9e573
Compare
Adds two endpoints - `/v1/query/prepare` - `/v1/query/execute` These add REST APIs around the spans core feature. They take as input a [span query](https://github.com/IBM/spnl). This PR also adds an example query under examples/offline-inference/spans/query-{ab,ba},json. See the [spans readme](examples/offline-inference/spans/README.md) for an example of usage. Signed-off-by: Nick Mitchell <[email protected]>
Signed-off-by: Nick Mitchell <[email protected]>
starpit
force-pushed
the
spnl-ibm
branch
4 times, most recently
from
7ca6395 to
4f6147f
Compare
Signed-off-by: Nick Mitchell <[email protected]>
2 participants
Purpose
This PR adds two endpoints
/v1/query/prepare/v1/query/executeThese add REST APIs around the spans core feature. They take as input a span query. This PR also adds an example query under examples/offline-inference/spans/query-{ab,ba},json. See the spans readme for an example of usage.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.