Skip to content

fixrule(svg_graphics_labelled, img_alt_valid) Ignore SVG & Image accessible name requirement when its ancestor is a widget or requires presentational child V4 #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main-4.x
Choose a base branch
from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented May 5, 2025

  • Rule bug: svg_graphics_labelled, img_alt_valid

This PR is related to the following issue(s):

Testing reference:

  • test/v2/checker/accessibility/rules/svg_graphics_labelled_ruleunit/svg_name_ignore.html
    Before the fix, 2 violations on "The SVG element has no accessible name".
    After the fix, only 1 of the violations shows up.
  • test/v2/checker/accessibility/rules/img_alt_valid_ruleunit/img_name_ignore.html
    Before the fix, 5 violations on "The image has neither an accessible name nor is marked as decorativ"
    After the fix, only 3 of the violations show up.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy requested review from tombrunet and philljenkins May 5, 2025 16:00
@shunguoy shunguoy marked this pull request as ready for review May 5, 2025 16:01
@shunguoy shunguoy changed the title fixrule(svg_graphics_labelled, img_alt_valid) Ignore SVG accessible name requirement when its ancestor is a widget or requires presentational child V4 fixrule(svg_graphics_labelled, img_alt_valid) Ignore SVG & Image accessible name requirement when its ancestor is a widget or requires presentational child V4 May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore SVG accessible name requirement when the svg is used as the image of a button with an accessible name
2 participants