Review (CO) #22
Open
Review (CO) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJishWang
reviewed
Sep 8, 2021
| d) This statement is confusing to me; is it best to use FIFEforSpark in Databricks, or in a Python IDE? | ||
| In either case, it's not clear how to get set up and install FIFEforSpark and all of the required dependencies | ||
| e) I get a "ModuleNotFoundError: No module named 'findspark'" error message when running `import findspark` | ||
| in Databricks (using Databricks Runtime 8.3/Spark 3.1.1/Scala 2.12) |
There was a problem hiding this comment.
The 'findspark' package is only necessary when running spark on the command line or a Python IDE, as opposed to on Databricks (which already preconfigures the cluster). We'll make this more clear in the README file!
EdJishWang
reviewed
Sep 10, 2021
| `java.lang.NoClassDefFoundError: org/apache/spark/ml/util/MLWritable$class`; note that importing | ||
| `fifeforspark.lgb_modelers` succeeds without triggering the warning that MMLSpark could not be imported; | ||
| using 8.3 Databricks Runtime, mmlspark_2.11-1.0.0-rc3 Maven coordinates for MMLSpark; full traceback is in | ||
| [3a_error_buildmodel.txt](3a_error_buildmodel.txt) |
There was a problem hiding this comment.
I think this is a cluster and maven coordinate incompatibility error. Can you try running using Databricks runtime 9.0? Also with the following maven coordinates: com.microsoft.ml.spark:mmlspark_2.12:1.0.0-rc3-59-bf337941-SNAPSHOT
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a pull request to add comments/feedback (will delete pull request later)