Repository navigation
Fix rejection logic for OCR jobs - #75
Merged
Merged
Conversation
Reject had no state check. Rejecting an approved job left its menu rows live under a "rejected" label, and rejecting a pending or processing job was silently overwritten when the worker finished. Reject now accepts the same states as approve (ready_for_review, failed) and returns 409 otherwise; the admin page already shows the server's message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that only reviewable OCR jobs can be rejected. This change prevents approved jobs from being incorrectly labeled as rejected and avoids overwriting the status of pending or processing jobs. The rejection logic now aligns with the approval logic, returning appropriate conflict responses for non-reviewable jobs. Tests have been updated to reflect these changes.