Airfoil markdown documentation + Apptainer tmp workaround. #177
Conversation
|
|
||
| # if APPTAINER_BIND_TMP, add an additional mount for /tmp to /tmp | ||
| if os.environ.get("APPTAINER_BIND_TMP", "false").lower() in ("1", "true", "yes"): | ||
| mounts = list(mounts) + [("/tmp", "/tmp")] # noqa: RUF005, S108 |
There was a problem hiding this comment.
@g-braeunlich this makes me think of #155. I am starting to be more confused than sure of what we're doing here. I think we should sit somewhere and discuss/define:
- The current Apptainer behavior
- The Docker behavior (and why we have problems even with --compat)
- The behavior we want
I'm thinking of just laying down all the information we have in a single issue because there are many different things happening on Airfoil.
There was a problem hiding this comment.
ruff is passing for all the changes I made - I think it is failing in photonics. Not sure why the main branch is passing or why my local branch is failing. ruff check locally says everything passed.
There was a problem hiding this comment.
I gave up on trying to fix my own docker problems too. I think Apptainer is solvable at least since no permissions are required, while docker requires the user to be added to a privileged docker group in order to do anything.
There was a problem hiding this comment.
Re-ran tests on main: ruff is failing on main :(
There was a problem hiding this comment.
@cashend This is due to the latest ruff release (0.13). It comes with new lints, in particular with
unused-unpacked-variable (RUF059).
Also see https://astral.sh/blog/ruff-v0.13.0
There was a problem hiding this comment.
@ffelten Yes, lets discuss that. On Wednesday, I would be in CLA if that is not too late for you
|
ruff issues fixed in #179 |
|
See #180 for the workaround part. |
Description
Airfoil markdown documentation. tmp directory linux desktop workaround using an environment variable.
Seen error:
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .