docs: add feedback on reactive templating system#3220
Open
chrismclarke wants to merge 1 commit intomasterfrom
Open
docs: add feedback on reactive templating system#3220chrismclarke wants to merge 1 commit intomasterfrom
chrismclarke wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Find attached a rough markdown document summarising some of the feedback I have for the reactive templating system, following an overview call with Johnny today.
I initially wrote pretty rough notes which I put through AI (why it feels more on the ai-generated side), but it does still capture the main things I wanted to share so hopefully can serve some useful reference.
Review Notes
I don't think it really needs review ahead of merge, but thought having it alongside the current code might make for useful reference (and give me an entry point for continued feedback as things develop)
@jfmcquade - if you think there's anything we discussed that's clealy missing from the doc let me know and I can try update.
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes