Skip to content

Added missing validation/ subdirectory to CoDICE validation data paths #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bourque merged 2 commits into from
Jun 25, 2025
Merged

Added missing validation/ subdirectory to CoDICE validation data paths #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f76e1
added missing validation/ subdirectory to CoDICE validation data paths
bourque Jun 25, 2025
7cb673e
Added code to create parent directory if necessary
bourque Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions imap_processing/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ def _download_external_data():
Path(f"{imap_module_directory}/tests") / destination_path / source_filename
)

# Create parent directories if they don't exist
destination.parent.mkdir(parents=True, exist_ok=True)

# Download the test data if necessary and write it to the appropriate
# directory
if not destination.exists():
Expand Down
36 changes: 18 additions & 18 deletions imap_processing/tests/external_test_data_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,24 @@
("imap_codice_l1a_lo-sw-priority_20241110_v999.cdf", "codice/data/"),
("imap_codice_l1a_lo-sw-species_20241110_v999.cdf", "codice/data/"),

("imap_codice_l1a_hi-counters-aggregated_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-counters-singles_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-counters-singles_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-ialirt_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-ialirt_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-nsw-angular_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-omni_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-nsw-priority_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-pha_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-nsw-species_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-priorities_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-pha_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-sectored_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-sw-angular_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hskp_20241110193622_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-sw-priority_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-counters-aggregated_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_lo-sw-species_20241110193700_v0.0.0.cdf", "codice/data/"),
("imap_codice_l1a_hi-counters-aggregated_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-counters-singles_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hi-counters-singles_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-ialirt_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hi-ialirt_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-nsw-angular_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hi-omni_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-nsw-priority_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hi-pha_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-nsw-species_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hi-priorities_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-pha_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hi-sectored_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-sw-angular_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_hskp_20241110193622_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-sw-priority_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-counters-aggregated_20241110193700_v0.0.0.cdf", "codice/data/validation/"),
("imap_codice_l1a_lo-sw-species_20241110193700_v0.0.0.cdf", "codice/data/validation/"),

# Hi
("imap_hi_l1a_45sensor-de_20250415_v999.cdf", "hi/data/l1/"),
Expand Down