Ultra l1a - added cdf for apid 882#1854
Ultra l1a - added cdf for apid 882#1854laspsandoval merged 5 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
greglucas
left a comment
There was a problem hiding this comment.
The branch is called ialirt_cdf_updates, but this does look like it only contains ultra l1a 882 changes. I have a minor suggestion for refactoring the function to be more general, but that might be a good follow-up task for @lacoak21 and would get her familiar with the unpacking L0 data.
While working through these, I don't think metadata on l1a products is important, so don't feel like we need to add all the variable information right now, that can easily come later IMO. If it is easiest just to do it at the same time then that is fine but just don't think you need to do it if it is slowing everything down.
| return ds | ||
|
|
||
|
|
||
| def process_ultra_energy_rates(ds: xr.Dataset) -> xr.Dataset: |
There was a problem hiding this comment.
This is very close to the above function. If you are going to be doing this on other rate-type packets too it might be good to abstract the boilerplate stuff out and pass in the apid/enum to do the lookup of the packet-specific things within a common function instead of needing to duplicate all the looping/logic.
def process_rates_l0(ds, packet_enum):
# Lookup from whatever enum you passed in
packet_enum.width, ...There was a problem hiding this comment.
Yes. I know. This is the last rates packet, though.
cb333b9
into
IMAP-Science-Operations-Center:dev
Change Summary
Overview
Added apid 882 (energy rates)
Updated Files
Testing
conftest.py
test_decom_apid_882.py
test_ultra_l1a.py