IDEX l2b add counts and reorganize CDF structure #1855
Merged
lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom Jul 8, 2025
Merged
IDEX l2b add counts and reorganize CDF structure #1855lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
lacoak21
requested review from
maxinelasp and
tmplummer
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the IDEX L2B processing to accommodate monthly cadence by reorganizing the CDF structure and adding new counts and rates functionality. Key changes include:
- Updates to test fixtures and test functions to support multiple L2A datasets and new binning methods.
- Major revisions in imap_processing/idex/idex_l2b.py including new functions for counting and rate computation, and updated constants and CDF configurations.
- Updates to CLI and YAML config files to reflect the change from weekly to monthly data products.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| imap_processing/tests/idex/test_idex_l2b.py | Modified tests to use the new bin_spin_phases function, update expected Logical_source names, and add tests for new count and rate functions. |
| imap_processing/tests/idex/conftest.py | Revised fixture to load L2A test data from CDF instead of using idex_l2a. |
| imap_processing/idex/idex_l2b.py | Refactored L2B processing to accept multiple L2A datasets and added functions for count binning and rate calculation. |
| imap_processing/idex/idex_constants.py | Added new constants for SECONDS_IN_DAY and FG_TO_KG. |
| imap_processing/cli.py | Updated file descriptor usage to reflect monthly cadence. |
| imap_processing/cdf/config/imap_idex_l2b_variable_attrs.yaml | Updated metadata to support new rate and count variables. |
| imap_processing/cdf/config/imap_idex_global_cdf_attrs.yaml | Changed global attributes from weekly to monthly data products. |
tmplummer
reviewed
Jun 27, 2025
Contributor
tmplummer
left a comment
tmplummer
left a comment
There was a problem hiding this comment.
First pass review... This all looks good to me. Just one comment about the possibility of using the np.histogramdd function.
greglucas
reviewed
Jun 27, 2025
greglucas
approved these changes
Jul 8, 2025
Collaborator
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Looks great. Just some minor nits from me that you can take/leave as you feel fit.
lacoak21
force-pushed
the
idex_l2b_team_updates
branch
from
17a3c6d to
5a39931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Add updates that were requested from the IDEX team. This includes adding rates and reorganizing the CDF structure. Each epoch will now represent one day. L2b is now a monthly "cadence" job.
Updated Files
Testing
Add testing for new l2b functions