2374 lo l2 integrate cg correction for hf maps - prepare for lo integration#2381
Merged
tmplummer merged 10 commits intoIMAP-Science-Operations-Center:devfrom Nov 5, 2025
Conversation
tmplummer
added
Ins: Hi
tmplummer
force-pushed
the
2374-lo-l2---integrate-cg-correction-for-hf-maps
branch
from
f15677b to
16f9bff
Compare
greglucas
approved these changes
Nov 4, 2025
| ) | ||
|
|
||
| # Convert to Cartesian coordinates and store as DataArray | ||
| pset.data["look_direction"] = xr.DataArray( |
Collaborator
There was a problem hiding this comment.
I really like the dropping of all these "data" and "values" :)
tmplummer
force-pushed
the
2374-lo-l2---integrate-cg-correction-for-hf-maps
branch
from
16f9bff to
a9c0db1
Compare
… -> int64 conversion
Improve test so that bug would be caught locally
tmplummer
merged commit 53a6cd0
into
IMAP-Science-Operations-Center:dev
14 checks passed
tmplummer
deleted the
2374-lo-l2---integrate-cg-correction-for-hf-maps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
There are two main changes in this PR:
Other changes were cascaded from the above main changes: