Skip to content

ULTRA l2 add backwards compatibility for old PSETS#2928

Merged
lacoak21 merged 3 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21:ultra_l2_backwards_pset_compatibility
Apr 8, 2026
Merged

ULTRA l2 add backwards compatibility for old PSETS#2928
lacoak21 merged 3 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21:ultra_l2_backwards_pset_compatibility

Conversation

@lacoak21
Copy link
Copy Markdown
Contributor

@lacoak21 lacoak21 commented Apr 7, 2026

Change Summary

closes #2927

Overview

Add a check for teh counts_pixel_index dimension. If it does not exist, skip the downsample code.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds ULTRA L2 backward compatibility when ingesting older PSET datasets by skipping the counts downsampling logic if the expected counts_pixel_index dimension/coordinate isn’t present.

Changes:

  • Add an early-exit guard in UltraPointingSet.downsample_counts() to skip downsampling when counts_pixel_index is missing.
  • Log an informational message when downsampling is skipped for compatibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@tmplummer tmplummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lacoak21 lacoak21 merged commit 674f4e1 into IMAP-Science-Operations-Center:dev Apr 8, 2026
14 checks passed
@lacoak21 lacoak21 deleted the ultra_l2_backwards_pset_compatibility branch April 8, 2026 17:14
@github-project-automation github-project-automation bot moved this to Done in IMAP Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ULTRA l2 downsample counts backwards compatibility

3 participants