Skip to content

Ip dead time variable idex l1b#2942

Closed
aldo9253 wants to merge 0 commit intoIMAP-Science-Operations-Center:devfrom
aldo9253:ip_dead_time_variable_idex_l1b
Closed

Ip dead time variable idex l1b#2942
aldo9253 wants to merge 0 commit intoIMAP-Science-Operations-Center:devfrom
aldo9253:ip_dead_time_variable_idex_l1b

Conversation

@aldo9253
Copy link
Copy Markdown
Collaborator

@aldo9253 aldo9253 commented Apr 8, 2026

Updated IDEX idex_l1b.py to include dead time field and
corresponding validation filenames in conftest.py and
external_test_data_config.py. Regenerated the validation
products and verified that test_idex_l0.py, test_idex_l1a.py,
test_idex_l1b.py, test_idex_l2a.py, and test_idex_l2b.py pass.

@lacoak21 lacoak21 self-requested a review April 9, 2026 15:07
@lacoak21
Copy link
Copy Markdown
Contributor

lacoak21 commented Apr 9, 2026

Updated IDEX idex_l1b.py to include dead time field and corresponding validation filenames in conftest.py and external_test_data_config.py. Regenerated the validation products and verified that test_idex_l0.py, test_idex_l1a.py, test_idex_l1b.py, test_idex_l2a.py, and test_idex_l2b.py pass.

Nice! Usually we want to keep the PR template and fill it out. You can look at other PRs for examples. It should have an overview, a files changed, and a testing updates section. Let me know if you cant see the other PRs.

Another thing that is important is linking the PR to an issue. Once you make an issue you can write "closes # " in the PR descriptor and that will automatically close it for you.

@aldo9253 aldo9253 force-pushed the ip_dead_time_variable_idex_l1b branch from 8139613 to 8bda97c Compare April 9, 2026 15:42
@lacoak21
Copy link
Copy Markdown
Contributor

lacoak21 commented Apr 9, 2026

Hey Alex - can you remove the h5 file? For these test files, we upload them to AWS s3 and then in the background the test code pulls that file down. If you saw my email - if you send me the file I will upload it for you.

@lacoak21 lacoak21 requested a review from tech3371 April 9, 2026 17:02
@aldo9253 aldo9253 closed this Apr 9, 2026
@aldo9253 aldo9253 force-pushed the ip_dead_time_variable_idex_l1b branch from 0501ce5 to 7f33698 Compare April 9, 2026 21:24
@aldo9253
Copy link
Copy Markdown
Collaborator Author

aldo9253 commented Apr 9, 2026

We just pushed the files that you and Ethan just worked on. Let us know if there are any more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants