Add support for custom S3 endpoints (e.g., Hetzner) #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom S3 endpoints to enable connectivity with S3-compatible object storage providers like Hetzner Cloud. The core functionality remains unchanged while extending the AWS S3 connection system to handle custom endpoint URLs.
- Extended
awss3()function to accept an optionalendpoint_urlparameter - Updated
awscli()function to inject the--endpoint-urlflag into AWS CLI commands - Propagated the
endpoint_urlparameter throughout all S3 method wrappers
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| man/awss3.Rd | Added documentation for the new endpoint_url parameter |
| R/awss3.R | Modified main constructor to accept and store endpoint_url parameter |
| R/awscli.R | Enhanced CLI wrapper to handle custom endpoint URLs |
| R/syncAllFiles.R | Updated to pass endpoint_url to AWS CLI calls |
| R/sendFile.R | Updated to pass endpoint_url to AWS CLI calls |
| R/sendAllFiles.R | Updated to pass endpoint_url to AWS CLI calls |
| R/removeFile.R | Updated to pass endpoint_url to AWS CLI calls |
| R/listFiles.R | Updated to pass endpoint_url to AWS CLI calls |
| R/getFile.R | Updated to pass endpoint_url to AWS CLI calls |
| DESCRIPTION | Updated RoxygenNote version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
arunge
approved these changes
Oct 2, 2025
Contributor
arunge
left a comment
arunge
left a comment
There was a problem hiding this comment.
@jan-abel-inwt I added a new NEWS.md file. The changes look all good. I will merge them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for S3-compatible object storage providers that require a custom endpoint URL, such as Hetzner Cloud
The core rsync functionality remains unchanged, but the awss3 connection and all associated methods (
sendFile,listFiles,syncAllFiles, etc.) are updated to accept and utilize a newendpoint_urlparameter.Key Changes:
awss3()function: Now accepts an optionalendpoint_urlargument.awscli()function: Now accepts theendpoint_urland injects it into the system call via the--endpoint-urlflag, enabling communication with non-AWS S3 services.endpoint_urlis passed down toawscli()across all S3 method wrappers.