Add autoscale Enum and add alternative options - #1496
Open
oerc0122 wants to merge 4 commits into
Open
Conversation
oerc0122
force-pushed
the
1483-enum-autoscale
branch
2 times, most recently
from
October 30, 2024 16:46
180a53f to
b82c5b2
Compare
oerc0122
force-pushed
the
1483-enum-autoscale
branch
2 times, most recently
from
November 26, 2024 16:52
bdae550 to
69d6aa2
Compare
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
January 6, 2025 15:07
ac1093f to
f2a116a
Compare
oerc0122
changed the title
Enum and add alternative options
alexhroom
reviewed
Mar 25, 2025
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
March 25, 2025 11:56
f2a116a to
745ab30
Compare
alexhroom
approved these changes
Apr 10, 2025
alexhroom
left a comment
alexhroom
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me if the tests pass
alexhroom
requested changes
Apr 10, 2025
alexhroom
left a comment
alexhroom
left a comment
Collaborator
There was a problem hiding this comment.
wait nevermind, i missed that the CI was failing - the AutoScale enum needs Union imported from typing
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
April 25, 2025 12:55
7b31135 to
4f9af41
Compare
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
May 14, 2025 12:56
4f9af41 to
07dda6f
Compare
alexhroom
approved these changes
Jun 5, 2025
franzlang
added
the
P5
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
October 2, 2025 12:42
ae9c213 to
6a98844
Compare
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
March 17, 2026 11:50
6a98844 to
6ad039f
Compare
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
March 26, 2026 13:28
6ad039f to
a65beba
Compare
Co-authored-by: Alex H. Room <69592136+alexhroom@users.noreply.github.com>
oerc0122
force-pushed
the
1483-enum-autoscale
branch
from
May 11, 2026 12:15
a65beba to
b296b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Add alternatives modes for autoscaling according to those described in #1483
Still needs documentation
Fixes
Migrated rescale factor calculation onto FoM calculator with
Enumtype selection. Can be passed as (case-insensitive) string, number (if known) or more usefully importingAutoScaleclass fromMDMC.refinement.FoMFixes #1483
To test
Updated tests