Move responsibility of H5MD dumping out of control - #1657
Open
oerc0122 wants to merge 3 commits into
Open
Conversation
oerc0122
added
the
housekeeping
oerc0122
force-pushed
the
split-h5md-dump
branch
2 times, most recently
from
April 13, 2026 15:04
8c2c468 to
81ef53c
Compare
Collaborator
|
I'm happy with the changes, including the |
oerc0122
force-pushed
the
split-h5md-dump
branch
3 times, most recently
from
April 14, 2026 09:24
e593e2c to
c00c3cb
Compare
Collaborator
|
It seems that |
oerc0122
force-pushed
the
split-h5md-dump
branch
3 times, most recently
from
April 27, 2026 15:42
b3591af to
be2d858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
control.py(unfortunate side effect, can pull out)Fixes
Starts process of breaking up monolithic control object.
To test
Check dumping works with different schemes.