Skip to content

Add docker-api-proxy service #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add docker-api-proxy service #969

wants to merge 3 commits into from

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Feb 12, 2025 •
edited
Loading

What do these changes do?

  • Add docker-api-proxy service
  • Fix validate_pydantic_settings_simcore CI Test

Security concerns

We need to monitor this service like every other. This implies running docker-api-proxy on monitored network.

Related issue/s

Related PR/s

Checklist

  • I tested and it works

New service introduction

  • Service has resource limits and reservations
  • Service has placement constraints or is global
  • Service is restartable
  • Service restart is zero-downtime
  • Service is not bound to one specific node (e.g. via files or volumes)
  • Service is monitored (by OPS services)
  • Relevant OPS E2E Test are added
  • Service's Public URL is included in maintenance mode

@YuryHrytsuk YuryHrytsuk added this to the Singularity milestone Feb 12, 2025
@YuryHrytsuk YuryHrytsuk requested a review from GitHK February 12, 2025 16:11
@YuryHrytsuk YuryHrytsuk self-assigned this Feb 12, 2025
GitHK
GitHK reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Resources look OK for now.

@YuryHrytsuk YuryHrytsuk force-pushed the introduce-docker-api-proxy-service branch from 1ca4852 to 1b4ac15 Compare February 13, 2025 09:36
This was referenced Mar 6, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
blocked / paused SECURITY
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.

Add configuration for new service docker-api-proxy
2 participants
@YuryHrytsuk @GitHK