-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Autoscaling: connect with rabbitmq #3620
✨ Autoscaling: connect with rabbitmq #3620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
========================================
+ Coverage 81.8% 83.9% +2.0%
========================================
Files 868 871 +3
Lines 36555 36658 +103
Branches 782 782
========================================
+ Hits 29922 30771 +849
+ Misses 6426 5680 -746
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
|
48dca77
to
a44b36a
Compare
f4f1f63
to
ff71907
Compare
aaadd25
to
4377e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
services/autoscaling/src/simcore_service_autoscaling/dynamic_scaling_core.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/dask_scheduler.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice: one question below about rabbit being not properly configured. I'm wondering what happens if there was a mistake in the DNS, when and where would that be seen
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/dask_scheduler.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
This PR connects the autoscaling app with RabbitMQ.
GET /status
to recover the current connection status with rabbit MQ (will be enhanced later with EC2, maybe Redis)Bonus:
closing the python-socketio AsyncServer needs some ad-hoc removal.
Related issue/s
needed for #3341
How to test
Checklist