♻️ Labels for metrics scraping

[GitHK]

What do these changes do?

• ♻️ moved SimcoreServiceDockerLabelKeys to models_library.docker
• added user project and node labels to "user services container".

Related issue/s

• Dy-Sidecar needs to export prometheus metrics resolved by userid #3721

How to test

Checklist

• Unit tests for the changes exist

[codecov]

Codecov Report

Merging #3881 (6deccdc) into master (3b883ba) will decrease coverage by 12.9%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master   #3881      +/-   ##
=========================================
- Coverage    83.5%   70.7%   -12.9%     
=========================================
  Files         419     668     +249     
  Lines       21371   30210    +8839     
  Branches      137     415     +278     
=========================================
+ Hits        17851   21360    +3509     
- Misses       3471    8751    +5280     
- Partials       49      99      +50     

Flag	Coverage Δ
integrationtests	66.0% <100.0%> (-0.7%)	⬇️
unittests	78.0% <80.0%> (-0.8%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...modules/dynamic_sidecar/scheduler/_core/_events.py	96.7% <ø> (-0.6%)	⬇️
...ckages/models-library/src/models_library/docker.py	86.2% <80.0%> (ø)
...v2/modules/dynamic_sidecar/docker_compose_specs.py	94.1% <100.0%> (-5.0%)	⬇️
...-v2/src/simcore_service_director_v2/cli/_client.py	0.0% <0.0%> (-100.0%)	⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py	0.0% <0.0%> (-100.0%)	⬇️
...r/src/simcore_service_webserver/storage_schemas.py	0.0% <0.0%> (-100.0%)	⬇️
...service_webserver/projects/_project_models_rest.py	0.0% <0.0%> (-100.0%)	⬇️
...service_director_v2/cli/_close_and_save_service.py	0.0% <0.0%> (-100.0%)	⬇️
...odules/dynamic_sidecar/scheduler/_core2/_errors.py	0.0% <0.0%> (-100.0%)	⬇️
...odules/dynamic_sidecar/scheduler/_core2/_marker.py	0.0% <0.0%> (-100.0%)	⬇️
... and 495 more

[mguidon]

Thanks

[sanderegg]

See my comments.
Also I do not understand why only the user_id is set and not the usual project/node as well.

[pcrespov]

Pls check my responses. we can perhaps check face-to-face to avoid further iterations :-) and accelerate

[pcrespov]

Thx! Please note the comment on the type annotation before merging.

[codeclimate]

Code Climate has analyzed commit 6deccdc and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.2% Duplication