🐛Docker buildx 0.10.2 does not resolve correctly ENVs in docker-compose labels section #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
bug
Codecov Report
@@ Coverage Diff @@
## master #4016 +/- ##
=========================================
- Coverage 83.9% 79.4% -4.5%
=========================================
Files 944 343 -601
Lines 40878 11542 -29336
Branches 849 539 -310
=========================================
- Hits 34320 9173 -25147
+ Misses 6349 2244 -4105
+ Partials 209 125 -84
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
requested review from
Surfict,
mrnicegyu11 and
pcrespov
as code owners
pcrespov
approved these changes
Mar 22, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit d4ed18a and detected 0 issues on this pull request. View more on Code Climate. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
docker buildx v0.10.2 has an issue with resolving environment variables in labels section when building
see docker/buildx#1631
upgrading to docker buildx v0.10.4
Important Note:
current version of ubuntu installs docker buildx 0.10.2 by defaults. As long as we do not push directly to the registry (the CI does that remember?). I think we do not have an issue.
But in any case it is easy to change the version of buildx locally if that is needed by following the instructions of docker buildx repo https://github.com/docker/buildx#installing
Related issue/s
fixes #4012
fixes ITISFoundation/osparc-issues#675
How to test
Checklist