Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 rclone command output is once again captured and not swallowed #4575

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 4, 2023

What do these changes do?

The output of rclone commands is once again captured.
Adjusted tests to catch this regression.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Aug 4, 2023
@GitHK GitHK added t:maintenance Some planned maintenance work changelog:🐛bugfix labels Aug 4, 2023
@GitHK GitHK added this to the Sundae milestone Aug 4, 2023
@GitHK GitHK marked this pull request as ready for review August 4, 2023 12:36
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4575 (53d2cc0) into master (169e0e7) will decrease coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4575     +/-   ##
========================================
- Coverage    82.8%   82.1%   -0.8%     
========================================
  Files        1023     744    -279     
  Lines       43763   34047   -9716     
  Branches     1014     188    -826     
========================================
- Hits        36251   27956   -8295     
+ Misses       7293    6054   -1239     
+ Partials      219      37    -182     
Flag Coverage Δ
unittests 82.1% <100.0%> (-0.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...e-sdk/src/simcore_sdk/node_ports_common/r_clone.py 79.7% <100.0%> (+9.8%) ⬆️
...src/simcore_sdk/node_ports_common/r_clone_utils.py 58.3% <100.0%> (+11.9%) ⬆️

... and 284 files with indirect coverage changes

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx

@GitHK GitHK enabled auto-merge (squash) August 4, 2023 12:53
@codeclimate
Copy link

codeclimate bot commented Aug 7, 2023

Code Climate has analyzed commit 53d2cc0 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit b6ef630 into ITISFoundation:master Aug 7, 2023
@GitHK GitHK deleted the pr-osparc-fix-rclone-logs branch August 7, 2023 11:11
@sanderegg sanderegg changed the title 🐛 rclone command output is once again captured and now swallowed 🐛 rclone command output is once again captured and not swallowed Aug 15, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants