♻️Maintenance: remove backward compatibility code #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnicegyu11
approved these changes
Aug 21, 2023
matusdrobuliak66
approved these changes
Aug 21, 2023
sanderegg
requested review from
mrnicegyu11,
matusdrobuliak66 and
bisgaard-itis
matusdrobuliak66
approved these changes
Aug 21, 2023
pcrespov
approved these changes
Aug 21, 2023
sanderegg
force-pushed
the
maintenance/remove-backward-useless-code
branch
from
aa29a2e to
f397a6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4632 +/- ##
=========================================
- Coverage 84.0% 65.2% -18.8%
=========================================
Files 1049 419 -630
Lines 44586 21903 -22683
Branches 1016 0 -1016
=========================================
- Hits 37458 14294 -23164
- Misses 6909 7609 +700
+ Partials 219 0 -219
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
sanderegg
changed the title
|
Code Climate has analyzed commit bd95b0b and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
since release 1.56.0, the code from #4453 for backward compatibility can be safely removed, thus cleaning the logs.
Related issue/s
How to test
DevOps Checklist