-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 removing unsubscribe from rabbitmq + ♻️ comp resource tracking id change #4687
🐛 removing unsubscribe from rabbitmq + ♻️ comp resource tracking id change #4687
Conversation
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker.py
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4687 +/- ##
=========================================
- Coverage 82.5% 68.1% -14.4%
=========================================
Files 985 476 -509
Lines 42120 24180 -17940
Branches 675 190 -485
=========================================
- Hits 34777 16489 -18288
- Misses 7191 7644 +453
+ Partials 152 47 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct way.
The queue shall be defined as durable pour similar, so that it is not automatically deleted. I can show you how to achieve this tomorrow
I have changed the resource tracking id (added node id for uniqueness) + For now just unsubscribed from rabbitmq (some tests depend on it, so I will need more time to remove the function totally and will do it some other time) |
Code Climate has analyzed commit 7407677 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
Related issue/s
How to test
DevOps Checklist