Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 removing unsubscribe from rabbitmq + ♻️ comp resource tracking id change #4687

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 30, 2023

What do these changes do?

  • 🐛 When unsubscribing from the rabbitmq the queue is deleted. What can happen is that during redeployment / or running more replicas firstly the queue is created, but then it is deleted by the previous service (that is shutting down). As this is an import queue that should be always there I removed the unsubscribe from rabbitmq for now.
  • ♻️ comp resource tracking id change

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Baklava milestone Aug 30, 2023
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 30, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 30, 2023 09:32
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4687 (7407677) into master (831c5e7) will decrease coverage by 14.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4687      +/-   ##
=========================================
- Coverage    82.5%   68.1%   -14.4%     
=========================================
  Files         985     476     -509     
  Lines       42120   24180   -17940     
  Branches      675     190     -485     
=========================================
- Hits        34777   16489   -18288     
- Misses       7191    7644     +453     
+ Partials      152      47     -105     
Flag Coverage Δ
integrationtests 61.0% <100.0%> (+<0.1%) ⬆️
unittests 85.7% <100.0%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rector_v2/modules/comp_scheduler/base_scheduler.py 90.7% <ø> (+8.7%) ⬆️
...rector_v2/modules/comp_scheduler/dask_scheduler.py 93.2% <ø> (+1.9%) ⬆️
...imcore_service_director_v2/utils/comp_scheduler.py 100.0% <100.0%> (ø)
...service_resource_usage_tracker/modules/rabbitmq.py 91.6% <100.0%> (+4.1%) ⬆️
...service_resource_usage_tracker/resource_tracker.py 100.0% <100.0%> (ø)

... and 792 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 30, 2023 11:12
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct way.
The queue shall be defined as durable pour similar, so that it is not automatically deleted. I can show you how to achieve this tomorrow

@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 removing unsubscribe from rabbitmq 🐛 removing unsubscribe from rabbitmq + comp resource tracking id change Aug 31, 2023
@matusdrobuliak66
Copy link
Contributor Author

This is not the correct way. The queue shall be defined as durable pour similar, so that it is not automatically deleted. I can show you how to achieve this tomorrow

I have changed the resource tracking id (added node id for uniqueness) + For now just unsubscribed from rabbitmq (some tests depend on it, so I will need more time to remove the function totally and will do it some other time)

@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 removing unsubscribe from rabbitmq + comp resource tracking id change 🐛 removing unsubscribe from rabbitmq + ♻️ comp resource tracking id change Aug 31, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 31, 2023

Code Climate has analyzed commit 7407677 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants