Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix bool in query parameter #4690

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • 🐛 fix bool in query parameter

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 30, 2023 13:40
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 30, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Baklava milestone Aug 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit 9e84fec and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4690 (9e84fec) into master (12dd548) will decrease coverage by 1.4%.
The diff coverage is 83.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4690      +/-   ##
=========================================
- Coverage    83.3%   81.9%    -1.4%     
=========================================
  Files         955     412     -543     
  Lines       38665   21401   -17264     
  Branches     1023     190     -833     
=========================================
- Hits        32214   17532   -14682     
+ Misses       6222    3822    -2400     
+ Partials      229      47     -182     
Flag Coverage Δ
integrationtests 66.5% <66.6%> (+22.6%) ⬆️
unittests 82.5% <83.3%> (-1.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...er/resource_usage/resource_usage_tracker_client.py 44.1% <ø> (ø)
...webserver/resource_usage/_service_runs_handlers.py 95.7% <83.3%> (-4.3%) ⬇️

... and 834 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 merged commit 40dbd14 into ITISFoundation:master Aug 30, 2023
@matusdrobuliak66 matusdrobuliak66 deleted the is922/resource-usage-services-endpoint-fix branch August 30, 2023 14:51
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants