Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🗃️ adding product_name to the wallets api #4780

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Sep 20, 2023

What do these changes do?

  • ✨ constrain wallets to the specific product (we will have it more under control, we do not need to propagate to the frontend usage of different products (if the same wallet would be used cross product), also we do not need to worry that wallet would be to up from different product which might have different prices)
  • 🗃️ already created wallets will be set to the s4l product (we are still in the testing phase), alternatively I can delete all of them

Related issue/s

How to test

DevOps Checklist

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4780 (cd42509) into master (1d1c5d6) will increase coverage by 0.7%.
The diff coverage is 93.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4780     +/-   ##
========================================
+ Coverage    86.9%   87.6%   +0.7%     
========================================
  Files        1150    1012    -138     
  Lines       47887   43142   -4745     
  Branches     1023     508    -515     
========================================
- Hits        41618   37826   -3792     
+ Misses       6037    5195    -842     
+ Partials      232     121    -111     
Flag Coverage Δ
integrationtests 63.5% <33.3%> (-1.5%) ⬇️
unittests 85.3% <93.3%> (+0.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...se/src/simcore_postgres_database/models/wallets.py 100.0% <ø> (ø)
...simcore_service_webserver/director_v2/_handlers.py 92.7% <ø> (-1.7%) ⬇️
...re_service_webserver/projects/_wallets_handlers.py 96.6% <ø> (ø)
...simcore_service_webserver/projects/projects_api.py 83.7% <ø> (-8.6%) ⬇️
...vice_webserver/resource_usage/_service_runs_api.py 100.0% <ø> (ø)
...rver/src/simcore_service_webserver/wallets/_api.py 88.2% <ø> (ø)
...core_service_webserver/wallets/_groups_handlers.py 97.5% <ø> (ø)
...src/simcore_service_webserver/wallets/_handlers.py 98.4% <ø> (ø)
...re_service_webserver/wallets/_payments_handlers.py 98.3% <ø> (ø)
...erver/src/simcore_service_webserver/wallets/_db.py 81.8% <66.6%> (+0.3%) ⬆️
... and 4 more

... and 144 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 20, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the the nameless milestone Sep 20, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 20, 2023 14:57
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 just a small remark

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 21, 2023 12:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit cd42509 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit 21a5223 into ITISFoundation:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallets should be on the product level
4 participants