♻️✨ refactoring of pricing plans (🗃️) #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #4812 +/- ##
========================================
+ Coverage 82.9% 87.3% +4.4%
========================================
Files 1154 1045 -109
Lines 48048 44734 -3314
Branches 1040 629 -411
========================================
- Hits 39867 39093 -774
+ Misses 7948 5498 -2450
+ Partials 233 143 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
requested review from
pcrespov,
sanderegg,
GitHK and
odeimaiz
as code owners
GitHK
reviewed
Oct 2, 2023
...ges/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_units.py
Show resolved
Hide resolved
...acker/src/simcore_service_resource_usage_tracker/modules/db/repositories/resource_tracker.py
Show resolved
Hide resolved
...acker/src/simcore_service_resource_usage_tracker/modules/db/repositories/resource_tracker.py
Show resolved
Hide resolved
...racker/src/simcore_service_resource_usage_tracker/services/resource_tracker_pricing_plans.py
Show resolved
Hide resolved
...racker/src/simcore_service_resource_usage_tracker/services/resource_tracker_pricing_plans.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Oct 2, 2023
...es-database/src/simcore_postgres_database/models/resource_tracker_pricing_plan_to_service.py
Show resolved
Hide resolved
...ces/web/server/src/simcore_service_webserver/resource_usage/resource_usage_tracker_client.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/catalog/_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_pricing_plans.py
Outdated
Show resolved
Hide resolved
|
Extra note: how much of this code is test-covered? Did you check e.g. in https://app.codecov.io/gh/ITISFoundation/osparc-simcore/tree/master/services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fresource_usage |
GitHK
approved these changes
Oct 2, 2023
pcrespov
approved these changes
Oct 2, 2023
services/web/server/tests/unit/with_dbs/03/resource_usage/test_pricing_plans.py
Outdated
Show resolved
Hide resolved
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
…ub.com:matusdrobuliak66/osparc-simcore into is1133/create-api-for-creation-of-pricing-plan
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit b4b78f0 and detected 0 issues on this pull request. View more on Code Climate. |
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
openapi.json specs
/v0/services/-/resource-usagesnow returns real cost + status whether it was billed or not/v0/catalog/services/{service_key}/{service_version}/pricing-plan/v0/pricing-plans/{pricing_plan_id}/pricing-units/{pricing_unit_id}/v1/services/{service_key}/{service_version}/pricing-plan/v1/pricing-plans/{pricing_plan_id}/pricing-units/{pricing_unit_id}Describe the overall billing plan/package. The pricing plan can be connected to one or more services. A specific pricing plan might be defined also for billing storage costs.
Specifies the various units within a pricing plan that denote different levels or segments. For example, a specific pricing plan might offer three tiers based on resources: SMALL, MEDIUM, and LARGE.
Defines the credit cost for each unit, which can change over time, allowing for pricing flexibility.
resource_usage_pricing_*tablesRelated issue/s
How to test
DevOps Checklist