-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ adding migration of projects_nodes + connect pricing-unit with project_nodes endpoint ( ποΈ) #4834
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4834 +/- ##
========================================
+ Coverage 78.3% 88.2% +9.9%
========================================
Files 627 634 +7
Lines 29032 29519 +487
Branches 203 323 +120
========================================
+ Hits 22750 26061 +3311
+ Misses 6232 3383 -2849
- Partials 50 75 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cooL!
I assume you checked it against existing data
...re_postgres_database/migration/versions/605fc07e068d_project_nodes_modification_creation_.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects_nodes.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, I will start working on the public api endpoints now
Kudos, SonarCloud Quality Gate passed!Β Β
|
Code Climate has analyzed commit 3d9512e and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
projects_nodes
tableprojects_node_to_pricing_unit
/projects/{project_id}/nodes/{node_id}/pricing-unit
/projects/{project_id}/nodes/{node_id}/pricing-plan/{pricing_plan_id}/pricing-unit/{pricing_unit_id}
/wallets/{wallet_id}
Related issue/s
How to test
DevOps Checklist