Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ adding migration of projects_nodes + connect pricing-unit with project_nodes endpoint ( πŸ—ƒοΈ) #4834

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 5, 2023

What do these changes do?

  • πŸ—ƒοΈ adds unique identification to the projects_nodes table
  • πŸ—ƒοΈ Introduce new table projects_node_to_pricing_unit
  • ✨ new endpoints: openapi.json specs
    • GET /projects/{project_id}/nodes/{node_id}/pricing-unit
    • PUT /projects/{project_id}/nodes/{node_id}/pricing-plan/{pricing_plan_id}/pricing-unit/{pricing_unit_id}
    • GET /wallets/{wallet_id}

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 5, 2023 14:24
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #4834 (3d9512e) into master (2cda9fd) will increase coverage by 9.9%.
The diff coverage is 95.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4834     +/-   ##
========================================
+ Coverage    78.3%   88.2%   +9.9%     
========================================
  Files         627     634      +7     
  Lines       29032   29519    +487     
  Branches      203     323    +120     
========================================
+ Hits        22750   26061   +3311     
+ Misses       6232    3383   -2849     
- Partials       50      75     +25     
Flag Coverage Ξ”
integrationtests 65.1% <53.5%> (-0.1%) ⬇️
unittests 86.5% <95.8%> (+7.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
...s_database/models/projects_node_to_pricing_unit.py 100.0% <100.0%> (ΓΈ)
...simcore_postgres_database/models/projects_nodes.py 100.0% <ΓΈ> (ΓΈ)
...erver/src/simcore_service_webserver/projects/db.py 98.0% <100.0%> (+0.3%) ⬆️
...r/src/simcore_service_webserver/projects/plugin.py 100.0% <100.0%> (ΓΈ)
...rc/simcore_service_webserver/resource_usage/api.py 81.2% <100.0%> (ΓΈ)
...rver/src/simcore_service_webserver/wallets/_api.py 88.1% <100.0%> (+0.8%) ⬆️
...src/simcore_service_webserver/wallets/_handlers.py 98.6% <100.0%> (+0.1%) ⬆️
...core_service_webserver/projects/_nodes_handlers.py 92.0% <80.0%> (ΓΈ)
...r/projects/_project_nodes_pricing_unit_handlers.py 95.8% <95.8%> (ΓΈ)

... and 429 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cooL!
I assume you checked it against existing data

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 9, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the the nameless milestone Oct 9, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title ✨ adding migration of projects_nodes ( πŸ—ƒοΈ) ✨ adding migration of projects_nodes + connect pricing-unit with project_nodes endpoint ( πŸ—ƒοΈ) Oct 9, 2023
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, I will start working on the public api endpoints now

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 9, 2023 14:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023

Code Climate has analyzed commit 3d9512e and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 9, 2023 16:06
@matusdrobuliak66 matusdrobuliak66 merged commit 7b16e96 into ITISFoundation:master Oct 9, 2023
@matusdrobuliak66 matusdrobuliak66 deleted the is922/store-selected-pricing-unit-with-the-node branch October 9, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants