Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› fix bug pricing plan listing + introduce unit_specific_info field (πŸ—ƒοΈ) #4839

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 7, 2023

What do these changes do?

  • πŸ› fixes a bug with listing pricing plans
  • ✨ introduce the unit_specific_info field in the pricing units πŸ—ƒοΈ (@odeimaiz )
  • ♻️ removes redundant specific_info field in the resource_tracker_pricing_unit_costs table πŸ—ƒοΈ

Related issue/s

How to test

DevOps Checklist

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4839 (8bd37cc) into master (d0bbb78) will decrease coverage by 0.2%.
The diff coverage is 71.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4839     +/-   ##
========================================
- Coverage    86.6%   86.4%   -0.2%     
========================================
  Files        1164    1049    -115     
  Lines       48380   44877   -3503     
  Branches     1040     629    -411     
========================================
- Hits        41925   38816   -3109     
+ Misses       6223    5919    -304     
+ Partials      232     142     -90     
Flag Coverage Ξ”
integrationtests 60.9% <ΓΈ> (-2.8%) ⬇️
unittests 84.7% <71.4%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
...pi_schemas_resource_usage_tracker/pricing_plans.py 100.0% <100.0%> (ΓΈ)
...ls_library/api_schemas_webserver/resource_usage.py 100.0% <100.0%> (ΓΈ)
...s_database/models/projects_node_to_pricing_unit.py 100.0% <ΓΈ> (ΓΈ)
...base/models/resource_tracker_pricing_unit_costs.py 100.0% <ΓΈ> (ΓΈ)
..._database/models/resource_tracker_pricing_units.py 100.0% <ΓΈ> (ΓΈ)
...service_resource_usage_tracker/core/application.py 100.0% <100.0%> (ΓΈ)
...core_service_resource_usage_tracker/core/errors.py 100.0% <100.0%> (ΓΈ)
...cker/models/resource_tracker_pricing_unit_costs.py 100.0% <ΓΈ> (ΓΈ)
...e_tracker/models/resource_tracker_pricing_units.py 100.0% <100.0%> (ΓΈ)
...tracker/services/resource_tracker_pricing_plans.py 100.0% <100.0%> (+4.3%) ⬆️
... and 3 more

... and 144 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 9, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the the nameless milestone Oct 9, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is922/fix bug pricing plan listing πŸ› fix bug pricing plan listing + introduce unit_attributes field (πŸ—ƒοΈ) Oct 9, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 9, 2023 06:47
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the error handling again. I think there is room for improvement. Check the handlers techinques in api-server as reference.

@matusdrobuliak66 matusdrobuliak66 changed the title πŸ› fix bug pricing plan listing + introduce unit_attributes field (πŸ—ƒοΈ) πŸ› fix bug pricing plan listing + introduce unit_specific_info field (πŸ—ƒοΈ) Oct 9, 2023
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way better

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To consider some enhanced renaming

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 9, 2023 15:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2023

Code Climate has analyzed commit 8bd37cc and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 10, 2023 07:54
@pcrespov pcrespov disabled auto-merge October 10, 2023 08:19
@pcrespov pcrespov merged commit edc0598 into ITISFoundation:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants