-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π fix bug pricing plan listing + introduce unit_specific_info field (ποΈ) #4839
π fix bug pricing plan listing + introduce unit_specific_info field (ποΈ) #4839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4839 +/- ##
========================================
- Coverage 86.6% 86.4% -0.2%
========================================
Files 1164 1049 -115
Lines 48380 44877 -3503
Branches 1040 629 -411
========================================
- Hits 41925 38816 -3109
+ Misses 6223 5919 -304
+ Partials 232 142 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/errors.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/errors.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the error handling again. I think there is room for improvement. Check the handlers techinques in api-server as reference.
...ges/postgres-database/src/simcore_postgres_database/models/resource_tracker_pricing_units.py
Show resolved
Hide resolved
...tracker/src/simcore_service_resource_usage_tracker/services/resource_tracker_service_runs.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_resource_tracker_pricing_plans.py
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/errors.py
Outdated
Show resolved
Hide resolved
...acker/src/simcore_service_resource_usage_tracker/modules/db/repositories/resource_tracker.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
way better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To consider some enhanced renaming
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/errors.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/errors.py
Show resolved
Hide resolved
β¦drobuliak66/osparc-simcore into is922/fix-bug-pricing-plan-listing
β¦o is922/fix-bug-pricing-plan-listing
Kudos, SonarCloud Quality Gate passed!Β Β
|
Code Climate has analyzed commit 8bd37cc and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
unit_specific_info
field in the pricing units ποΈ (@odeimaiz )specific_info
field in the resource_tracker_pricing_unit_costs table ποΈRelated issue/s
How to test
DevOps Checklist