Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Is922/select default wallet and pricing plan in the backend #4851

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 11, 2023

What do these changes do?

  • ♻️ select the default wallet in the backend

Next: select the default pricing plan in the backend

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 11, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the the nameless milestone Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4851 (4754b59) into master (a422201) will increase coverage by 3.0%.
The diff coverage is 63.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4851      +/-   ##
=========================================
+ Coverage    78.4%   81.4%    +3.0%     
=========================================
  Files        1178     505     -673     
  Lines       48878   25748   -23130     
  Branches     1063     195     -868     
=========================================
- Hits        38341   20974   -17367     
+ Misses      10302    4725    -5577     
+ Partials      235      49     -186     
Flag Coverage Δ
integrationtests 65.2% <43.3%> (+11.6%) ⬆️
unittests 86.4% <63.3%> (+8.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rver/src/simcore_service_webserver/products/_db.py 80.0% <ø> (+22.5%) ⬆️
...core_service_webserver/projects/_nodes_handlers.py 92.0% <100.0%> (+43.7%) ⬆️
...ore_service_webserver/projects/_states_handlers.py 92.9% <100.0%> (+39.8%) ⬆️
...simcore_service_webserver/projects/_wallets_api.py 100.0% <100.0%> (ø)
...re_service_webserver/projects/_wallets_handlers.py 96.3% <100.0%> (+26.8%) ⬆️
...rver/src/simcore_service_webserver/projects/api.py 100.0% <100.0%> (ø)
...simcore_service_webserver/users/preferences_api.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/wallets/_events.py 100.0% <100.0%> (+30.0%) ⬆️
...imcore_service_webserver/users/_preferences_api.py 96.6% <75.0%> (+25.2%) ⬆️
.../src/simcore_service_webserver/users/exceptions.py 75.0% <50.0%> (+25.0%) ⬆️
... and 2 more

... and 889 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is922/select default wallet and pricing plan in the backend ♻️ Is922/select default wallet and pricing plan in the backend Oct 13, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 13, 2023 12:16
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 13, 2023

Code Climate has analyzed commit 4754b59 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Security 1

View more on Code Climate.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. I left some comments on style

@matusdrobuliak66 matusdrobuliak66 merged commit 6b9e988 into ITISFoundation:master Oct 13, 2023
@matusdrobuliak66 matusdrobuliak66 deleted the is922/select-default-wallet-and-pricing-plan-in-the-backend branch October 13, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants