Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Select default wallet and pricing plan in the backend part 2 #4869

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 16, 2023

What do these changes do?

  • ♻️ Backend selects default pricing plan for dynamic services

NEXT PR: backend selects the default pricing plan for computation services (this needs to be done in director-v2)

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Microhistory milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #4869 (155bb9e) into master (ed6da73) will increase coverage by 0.2%.
The diff coverage is 68.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4869     +/-   ##
========================================
+ Coverage    85.4%   85.6%   +0.2%     
========================================
  Files        1185    1069    -116     
  Lines       49244   45787   -3457     
  Branches     1065     654    -411     
========================================
- Hits        42062   39224   -2838     
+ Misses       6956    6427    -529     
+ Partials      226     136     -90     
Flag Coverage Δ
integrationtests 76.2% <50.0%> (+18.5%) ⬆️
unittests 84.8% <68.8%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...library/api_schemas_directorv2/dynamic_services.py 96.4% <100.0%> (+0.4%) ⬆️
...els-library/src/models_library/resource_tracker.py 100.0% <100.0%> (ø)
...e_director_v2/models/dynamic_services_scheduler.py 98.8% <100.0%> (+4.0%) ⬆️
...cker/models/resource_tracker_pricing_unit_costs.py 100.0% <100.0%> (ø)
...src/simcore_service_webserver/catalog/_handlers.py 68.2% <100.0%> (ø)
...ce_webserver/director_v2/_core_dynamic_services.py 73.6% <100.0%> (+0.2%) ⬆️
...core_service_webserver/projects/_nodes_handlers.py 92.0% <100.0%> (ø)
...r/projects/_project_nodes_pricing_unit_handlers.py 95.9% <100.0%> (+0.1%) ⬆️
...erver/src/simcore_service_webserver/projects/db.py 96.0% <100.0%> (-1.2%) ⬇️
...ice_webserver/resource_usage/_pricing_plans_api.py 100.0% <100.0%> (ø)
... and 5 more

... and 165 files with indirect coverage changes

matusdrobuliak66 and others added 5 commits October 16, 2023 19:14
…ackend-part-2' and 'is922/select-default-wallet-and-pricing-plan-in-the-backend-part-2' of github.com:matusdrobuliak66/osparc-simcore into is922/select-default-wallet-and-pricing-plan-in-the-backend-part-2
…kend-part-2' of github.com:matusdrobuliak66/osparc-simcore into is922/select-default-wallet-and-pricing-plan-in-the-backend-part-2
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is922/select default wallet and pricing plan in the backend part 2 ♻️ Is922/select default wallet and pricing plan in the backend part 2 Oct 17, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 17, 2023 07:12
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 17, 2023 14:04
@codeclimate
Copy link

codeclimate bot commented Oct 17, 2023

Code Climate has analyzed commit 155bb9e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit 881ce5e into ITISFoundation:master Oct 17, 2023
@YuryHrytsuk YuryHrytsuk changed the title ♻️ Is922/select default wallet and pricing plan in the backend part 2 ♻️ Select default wallet and pricing plan in the backend part 2 Oct 19, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 20, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants