Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨new style dynamic-services shut down when wallet runs out of credits (⚠️ devops) #4922

Closed

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 25, 2023

What do these changes do?

  • ✨ when credits go under a threshold services new style dynamic services are shut down.
    TODO:
  • monitor status of legacy and new style dynamic services and publish differences
  • push messages via rabbitmq to the webserver which will distribute it to the right place?
  • connect the comp services as well

⚠️ Devops

  • extended redis connections added 2 new databases (needs propagation?)

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Oct 25, 2023
@GitHK GitHK added this to the Microhistory milestone Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4922 (ca98bcd) into master (5035fe5) will increase coverage by 13.1%.
Report is 1 commits behind head on master.
The diff coverage is 91.1%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4922      +/-   ##
=========================================
+ Coverage    64.8%   78.0%   +13.1%     
=========================================
  Files         526    1073     +547     
  Lines       26634   42550   +15916     
  Branches      198    1116     +918     
=========================================
+ Hits        17274   33191   +15917     
+ Misses       9310    9117     -193     
- Partials       50     242     +192     
Flag Coverage Δ
integrationtests 64.2% <ø> (-0.7%) ⬇️
unittests 76.9% <91.1%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ls-library/src/models_library/rabbitmq_messages.py 89.7% <100.0%> (ø)
packages/service-library/src/servicelib/redis.py 93.9% <100.0%> (ø)
...ges/settings-library/src/settings_library/redis.py 95.4% <100.0%> (ø)
...usage_tracker/resource_tracker_process_messages.py 91.9% <100.0%> (ø)
.../service-library/src/servicelib/background_task.py 88.8% <89.6%> (ø)

... and 953 files with indirect coverage changes

@GitHK GitHK changed the title ✨new style dynamic-services shut down when wallet runs out of credits ✨new style dynamic-services shut down when wallet runs out of credits (⚠️ devops) Oct 27, 2023
Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit ca98bcd and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK
Copy link
Contributor Author

GitHK commented Nov 21, 2023

replaced by #5058 and its followups

@GitHK GitHK closed this Nov 21, 2023
@GitHK GitHK deleted the pr-osparc-react-on-shutdown-event branch November 21, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant