-
Notifications
You must be signed in to change notification settings - Fork 125
[GradedAxes] Replace GradedAxes
with GradedAxesNext
#1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is pretty close to being ready, in the latest I've implemented taking the naive tensor product of two graded axes (for abelian symmetries, which was all that was implemented in the previous version of |
GradedAxes
with GradedAxesNext
GradedAxes
with GradedAxesNext
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
===========================================
- Coverage 84.40% 53.78% -30.62%
===========================================
Files 100 99 -1
Lines 8581 8528 -53
===========================================
- Hits 7243 4587 -2656
- Misses 1338 3941 +2603 ☔ View full report in Codecov by Sentry. |
As I understand, you redefined In doing so you removed the concept of I see 4 possibilities for
Overall, I believe that without the isdual information, |
It seems to me that no solution is optimal and a tradeoff needs to be made. To specify my position, I currently lean towards option 2), explicitly splitting the two concepts and implementing both. Indeed the two concepts are related, but they do not correspond exactly to the same use case:
It is easy to construct a Range from a Space, however the reverse may not be possible or imposes to set implicit conventions. EDIT: independently from this PR, last week I reached the conclusion that implementing |
@ogauthe let's discuss this issue around |
This is a followup to #1351.
I still need to implement a few missing functions for the new
GradedUnitRange
type related to fusion and sorting by sector/block labels.@ogauthe