Slow tests after (#7)

* Removes product_spec

* Adds shop model with associations between use and products

* Adds user account association with full name specs

* Adds shop builder specs

* Adds destroy product specs

* Adds view specs as part of the toolkit

* Fixes system views on the page object

* Refactors the view spec of product deletion

* Adds webmocl to stub requests

Author: kurenn

.bash_history

@@ -37,3 +37,7 @@ export
 export
 #!/bin/bash -i
 export
+#!/bin/bash -i
+export
+#!/bin/bash -i
+export

Gemfile

@@ -32,6 +32,7 @@ group :development do
   gem "annotate"
   gem "rack-timeout", require:"rack/timeout/base"
   gem "rails-erd"
+  gem 'httparty'
 
     # Support for Ruby IDE tools - including "Ruby for Visual Studio Code"
   gem 'debase', '~> 0.2.4.1'
@@ -55,6 +56,7 @@ group :test do
   gem "simplecov-console", "~> 0.4.2", require: false
   gem "simplecov-json", require: false
   gem "simplecov-reporter", require: false
+  gem 'webmock'
 end
 
 group :development, :test do
@@ -78,4 +80,4 @@ end
 
 gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
 
-gem "devise"
+gem "devise"

Gemfile.lock

@@ -99,6 +99,8 @@ GEM
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
     concurrent-ruby (1.1.6)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
     crass (1.0.6)
     debase (0.2.4.1)
       debase-ruby_core_source (>= 0.10.2)
@@ -125,6 +127,7 @@ GEM
     ffi (1.12.2)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
+    hashdiff (1.0.1)
     hirb (0.7.3)
     httparty (0.18.0)
       mime-types (~> 3.0)
@@ -276,6 +279,7 @@ GEM
     ruby-progressbar (1.10.1)
     ruby_dep (1.5.0)
     rubyzip (2.2.0)
+    safe_yaml (1.0.5)
     sass (3.7.4)
       sass-listen (~> 4.0.0)
     sass-listen (4.0.0)
@@ -354,6 +358,10 @@ GEM
       nokogiri (~> 1.6)
       rubyzip (>= 1.3.0)
       selenium-webdriver (>= 3.0, < 4.0)
+    webmock (3.8.2)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
     webpacker (4.2.2)
       activesupport (>= 4.2)
       rack-proxy (>= 0.6.1)
@@ -381,6 +389,7 @@ DEPENDENCIES
   devise
   factory_bot_rails
   ffaker
+  httparty
   listen (>= 3.0.5, < 3.2)
   normalize-rails
   pg (>= 0.18, < 2.0)
@@ -413,6 +422,7 @@ DEPENDENCIES
   tzinfo-data
   web-console (>= 3.3.0)
   webdrivers (~> 4.0)
+  webmock
   webpacker (~> 4.0)
 
 RUBY VERSION

app/controllers/products_controller.rb

@@ -1,4 +1,5 @@
 class ProductsController < ApplicationController
+  before_action :authenticate_user!, only: [:destroy, :update, :new, :create]
   before_action :set_product, only: [:show, :edit, :update, :destroy]
 
   # GET /products
@@ -53,6 +54,6 @@ def set_product
 
     # Only allow a trusted parameter "white list" through.
     def product_params
-      params.require(:product).permit(:name, :description, :price, :status)
+      params.require(:product).permit(:name, :description, :price, :status, :shop_id)
     end
 end

app/models/account.rb

@@ -0,0 +1,3 @@
+class Account < ApplicationRecord
+  belongs_to :user
+end

app/models/product.rb

@@ -8,4 +8,6 @@ class Product < ApplicationRecord
   validates :name,
             :description,
             :price, presence: true
+
+  belongs_to :shop
 end

app/models/shop.rb

@@ -0,0 +1,4 @@
+class Shop < ApplicationRecord
+  belongs_to :user
+  has_many :products
+end

app/models/user.rb

@@ -3,4 +3,17 @@ class User < ApplicationRecord
   # :confirmable, :lockable, :timeoutable, :trackable and :omniauthable
   devise :database_authenticatable, :registerable,
          :recoverable, :rememberable, :validatable
+  
+  has_many :shops
+  has_one :account
+
+  def full_name
+    "#{first_name} #{last_name}".strip
+  end
+
+  def shop_ready?
+    # completed_profile?
+      # && billing_information?
+      # && active_plan?
+  end
 end

app/services/shop_builder.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class ShopBuilder
+  def initialize(user)
+    @user = user
+  end
+
+  def build
+    if @user.shop_ready?
+      # charge_user!
+    end
+  end
+
+  private
+
+  def charge_user!
+    # ...
+  end
+end

app/views/products/_form.html.erb

@@ -26,6 +26,11 @@
     <%= form.text_field :price %>
   </div>
 
+  <div>
+    <%= form.label :shop_id %>
+    <%= form.collection_select :shop_id, current_user.shops, :id, :name, prompt: true %>
+  </div>
+
   <div class="actions">
     <%= form.submit 'Create' %>
   </div>

app/views/products/index.html.erb

@@ -20,7 +20,9 @@
         <td><%= product.price %></td>
         <td><%= link_to 'Show', product %></td>
         <td><%= link_to 'Edit', edit_product_path(product) %></td>
-        <td><%= link_to 'Destroy', product, method: :delete, data: { confirm: 'Are you sure?' } %></td>
+        <% if user_signed_in? && current_user.admin? %>
+          <td><%= link_to 'Destroy', product, method: :delete, data: { confirm: 'Are you sure?' } %></td>
+        <% end %>
       </tr>
     <% end %>
   </tbody>

app/views/products/show.html.erb

@@ -24,5 +24,9 @@
   <%= @product.price %>
 </p>
 
+<% if current_user.admin? %>
+  <%= link_to 'Destroy', @product, method: :delete, data: { confirm: 'Are you sure?' } %>
+<% end %>
+
 <%= link_to 'Edit', edit_product_path(@product) %> |
 <%= link_to 'Back', products_path %>

db/migrate/20200302175640_create_shops.rb

@@ -0,0 +1,10 @@
+class CreateShops < ActiveRecord::Migration[6.0]
+  def change
+    create_table :shops do |t|
+      t.string :name
+      t.references :user, null: false, foreign_key: true
+
+      t.timestamps
+    end
+  end
+end

db/migrate/20200302175718_add_shop_id_to_products.rb

@@ -0,0 +1,5 @@
+class AddShopIdToProducts < ActiveRecord::Migration[6.0]
+  def change
+    add_reference :products, :shop, null: false, foreign_key: true
+  end
+end

db/migrate/20200302182308_add_last_name_to_users.rb

@@ -0,0 +1,6 @@
+class AddLastNameToUsers < ActiveRecord::Migration[6.0]
+  def change
+    add_column :users, :last_name, :string
+    add_column :users, :first_name, :string
+  end
+end

db/migrate/20200302190422_create_accounts.rb

@@ -0,0 +1,9 @@
+class CreateAccounts < ActiveRecord::Migration[6.0]
+  def change
+    create_table :accounts do |t|
+      t.references :user, null: false, foreign_key: true
+
+      t.timestamps
+    end
+  end
+end

db/migrate/20200302194034_add_admin_to_users.rb

@@ -0,0 +1,5 @@
+class AddAdminToUsers < ActiveRecord::Migration[6.0]
+  def change
+    add_column :users, :admin, :boolean, default: false
+  end
+end

db/schema.rb

@@ -10,11 +10,18 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_02_27_193902) do
+ActiveRecord::Schema.define(version: 2020_03_02_194034) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
+  create_table "accounts", force: :cascade do |t|
+    t.bigint "user_id", null: false
+    t.datetime "created_at", precision: 6, null: false
+    t.datetime "updated_at", precision: 6, null: false
+    t.index ["user_id"], name: "index_accounts_on_user_id"
+  end
+
   create_table "net_promoter_scores", force: :cascade do |t|
     t.integer "score"
     t.datetime "created_at", precision: 6, null: false
@@ -28,6 +35,16 @@
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
     t.integer "status", default: 0
+    t.bigint "shop_id", null: false
+    t.index ["shop_id"], name: "index_products_on_shop_id"
+  end
+
+  create_table "shops", force: :cascade do |t|
+    t.string "name"
+    t.bigint "user_id", null: false
+    t.datetime "created_at", precision: 6, null: false
+    t.datetime "updated_at", precision: 6, null: false
+    t.index ["user_id"], name: "index_shops_on_user_id"
   end
 
   create_table "users", force: :cascade do |t|
@@ -38,8 +55,14 @@
     t.datetime "remember_created_at"
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.string "last_name"
+    t.string "first_name"
+    t.boolean "admin", default: false
     t.index ["email"], name: "index_users_on_email", unique: true
     t.index ["reset_password_token"], name: "index_users_on_reset_password_token", unique: true
   end
 
+  add_foreign_key "accounts", "users"
+  add_foreign_key "products", "shops"
+  add_foreign_key "shops", "users"
 end

erd.pdf

@@ -0,0 +1,5 @@
+FactoryBot.define do
+  factory :account do
+    user
+  end
+end

spec/factories/accounts.rb

@@ -3,5 +3,6 @@
     name { FFaker::Product.product_name }
     description { FFaker::Product.letters(200) }
     price { 100.0 }
+    shop
   end
 end

spec/factories/products.rb

@@ -0,0 +1,10 @@
+FactoryBot.define do
+  factory :shop do
+    name { FFaker::Company.name }
+    user
+
+    after(:create) do |shop|
+      create_list(:product, 3, shop: shop)
+    end
+  end
+end

spec/factories/shops.rb

@@ -1,7 +1,17 @@
 FactoryBot.define do
   factory :user do
+    first_name { FFaker::Name.first_name }
+    last_name { FFaker::Name.last_name }
     sequence(:email) {  |n| "test_user#{n}@mail.com" }
     password { '12345678' } 
     password_confirmation { '12345678' }
+
+    trait :as_admin do
+      admin { true }
+    end
+
+    after(:create) do |user|
+      create_list(:shop, 1, user: user)
+    end
   end
 end

spec/factories/users.rb

@@ -1,7 +1,5 @@
-# frozen_string_literal: true
-
 require 'rails_helper'
 
-RSpec.describe Product, type: :model do
+RSpec.describe Account, type: :model do
   pending "add some examples to (or delete) #{__FILE__}"
 end

spec/models/product_spec.rb renamed to spec/models/account_spec.rb

@@ -0,0 +1,5 @@
+require 'rails_helper'
+
+RSpec.describe Shop, type: :model do
+  pending "add some examples to (or delete) #{__FILE__}"
+end

spec/models/shop_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Shop, type: :model do
+  describe '#full_name' do
+
+    it 'returns the first_name and last_name concatenaded' do
+      user = create(:user, first_name: 'Naruto', last_name: 'Uzumaki')
+
+      expect(user.full_name).to eq 'Naruto Uzumaki'
+    end
+
+    it 'returns only the first_name if no last_name is provided' do
+      user = create(:user, first_name: 'Naruto', last_name: nil)
+
+      expect(user.full_name).to eq 'Naruto'
+    end
+  end
+end

spec/models/user_spec.rb

@@ -11,6 +11,8 @@
   abort('The Rails environment is running in production mode!')
 end
 require 'rspec/rails'
+require 'webmock/rspec'
+require 'httparty'
 # require 'simplecov_helper'
 # Add additional requires below this line. Rails is not loaded until this point!
 
@@ -65,6 +67,9 @@
   config.filter_rails_from_backtrace!
   # arbitrary gems may also be filtered via:
   # config.filter_gems_from_backtrace("gem name")
+
+  config.include Devise::TestHelpers, type: :view
+  config.include Warden::Test::Helpers
 end
 
 Shoulda::Matchers.configure do |config|

spec/rails_helper.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe ShopBuilder do
+  describe '#build' do
+    # https://relishapp.com/rspec/rspec-mocks/docs/basics/test-doubles
+    it 'builds the shop for valid users' do
+      user = instance_double(User, shop_ready?: true)
+
+      ShopBuilder.new(user).build
+
+      # here will come the expectation
+    end
+  end
+end

spec/services/shop_builder_spec.rb

@@ -14,6 +14,7 @@ def create
       fill_in :product_name, with: @name
       fill_in :product_description, with: 'description'
       fill_in :product_price, with: 500
+      select Shop.first.name, from: :product_shop_id
       click_button 'Create'
     end