Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix logger data race #71

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix: fix logger data race #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19d2678
fix: fix logger data race
CorrectRoadH Feb 18, 2025
249b1a2
fix duplicate init
CorrectRoadH Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions utils/logger/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"path"
"path/filepath"
"runtime"
"sync"

"github.com/samber/lo"
"go.uber.org/zap"
Expand All @@ -14,6 +15,7 @@ import (
)

var loggers *zap.Logger
var once sync.Once

func getFileLogWriter(logPath string, logFileName string, logFileExt string) (writeSyncer zapcore.WriteSyncer) {
// 使用 lumberjack 实现 log rotate
Expand All @@ -37,14 +39,17 @@ func LogInitWithWriterSyncers(syncers ...zapcore.WriteSyncer) {
func(syncer zapcore.WriteSyncer, index int) zapcore.Core {
return zapcore.NewCore(encoder, syncer, zapcore.InfoLevel)
})...,
))
),
)
}

// for unit tests
func LogInitConsoleOnly() {
LogInitWithWriterSyncers(
zapcore.AddSync(os.Stdout),
)
once.Do(func() {
LogInitWithWriterSyncers(
zapcore.AddSync(os.Stdout),
)
})
}

func LogInit(logPath string, logFileName string, logFileExt string) {
Expand Down