Skip to content

EventRuleConfig: Replace all attr callbacks with options #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EventRuleConfig: Replace all attr callbacks with options #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions application/forms/EventRuleConfigElements/ConfigProvider.php
View file
Open in desktop

This file was deleted.

29 changes: 6 additions & 23 deletions application/forms/EventRuleConfigElements/Escalation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use ipl\Html\FormElement\FieldsetElement;
use ipl\Html\FormElement\SubmitButtonElement;
use ipl\Html\HtmlElement;
use ipl\Stdlib\Option;
use ipl\Web\Widget\Icon;

/**
Expand All @@ -22,16 +23,17 @@
*/
class Escalation extends FieldsetElement
{
use ConfigProvider {
registerAttributeCallbacks as protected baseRegisterAttributeCallbacks;
}

protected $defaultAttributes = ['class' => 'escalation'];

/** @var ?ConfigProviderInterface The config provider */
#[Option(required: true)]
protected ?ConfigProviderInterface $provider = null;

/** @var ?SubmitButtonElement The button to remove this escalation */
protected ?SubmitButtonElement $removeButton = null;

/** @var bool Whether the escalation can be triggered immediately */
#[Option]
protected bool $immediate = false;

/**
Expand All @@ -46,18 +48,6 @@ public function setRemoveButton(SubmitButtonElement $removeButton): void
$this->removeButton = $removeButton;
}

/**
* Set whether the escalation can be triggered immediately
*
* @param bool $immediate
*
* @return void
*/
public function setImmediate(bool $immediate): void
{
$this->immediate = $immediate;
}

/**
* Prepare the escalation for display
*
Expand Down Expand Up @@ -163,11 +153,4 @@ protected function assemble(): void

$this->addElement('hidden', 'id');
}

protected function registerAttributeCallbacks(Attributes $attributes): void
{
$attributes->registerAttributeCallback('immediate', null, $this->setImmediate(...));

$this->baseRegisterAttributeCallbacks($attributes);
}
}
7 changes: 5 additions & 2 deletions application/forms/EventRuleConfigElements/EscalationRecipient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use ipl\Html\FormElement\FieldsetElement;
use ipl\Html\FormElement\SubmitButtonElement;
use ipl\Html\HtmlElement;
use ipl\Stdlib\Option;
use ipl\Web\Widget\Icon;

/**
Expand All @@ -27,10 +28,12 @@
*/
class EscalationRecipient extends FieldsetElement
{
use ConfigProvider;

protected $defaultAttributes = ['class' => 'escalation-recipient'];

/** @var ?ConfigProviderInterface The config provider */
#[Option(required: true)]
protected ?ConfigProviderInterface $provider = null;

/** @var ?SubmitButtonElement The button to remove this recipient */
protected ?SubmitButtonElement $removeButton = null;

Expand Down
6 changes: 5 additions & 1 deletion application/forms/EventRuleConfigElements/EscalationRecipients.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,22 @@
use ipl\Html\FormElement\FieldsetElement;
use ipl\Html\FormElement\SubmitButtonElement;
use ipl\Html\HtmlElement;
use ipl\Stdlib\Option;
use ipl\Web\Widget\Icon;

/**
* @phpstan-import-type RecipientData from EscalationRecipient
*/
class EscalationRecipients extends FieldsetElement
{
use ConfigProvider;
use DynamicElements;

protected $defaultAttributes = ['class' => 'escalation-recipients'];

/** @var ?ConfigProviderInterface The config provider */
#[Option(required: true)]
protected ?ConfigProviderInterface $provider = null;

protected function createAddButton(): SubmitButtonElement
{
/** @var SubmitButtonElement $button */
Expand Down
6 changes: 5 additions & 1 deletion application/forms/EventRuleConfigElements/Escalations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,22 @@
use ipl\Html\FormElement\FieldsetElement;
use ipl\Html\FormElement\SubmitButtonElement;
use ipl\Html\HtmlElement;
use ipl\Stdlib\Option;
use ipl\Web\Widget\Icon;

/**
* @phpstan-import-type EscalationData from Escalation
*/
class Escalations extends FieldsetElement
{
use ConfigProvider;
use DynamicElements;

protected $defaultAttributes = ['class' => 'escalations'];

/** @var ?ConfigProviderInterface The config provider */
#[Option(required: true)]
protected ?ConfigProviderInterface $provider = null;

protected function createAddButton(): SubmitButtonElement
{
/** @var SubmitButtonElement $button */
Expand Down
Loading